1711844 - Icons in Customize menu are slightly darker than if placed on the toolbar or inside Overflow menu while Light theme is used

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: imgonline-com-ua-twotoone-me6sl9BOGL.jpeg

Affected versions

• 90.0a1 (20210518213628)
• 89.0b14 (20210518190425)

Affected platforms

• macOS 11.3.1
• Windows 10x64

Steps to reproduce

1. Open Firefox and observe the icons.
2. Add one icon to the toolbar (e.g Print, Private Window, Text Encoding, Edit Controls)

Expected result

• The Icons have the same color.

Actual result

• Some icons are darker in Customize mode than on the toolbar or Overflow menu.

Regression range

• Last good revision: 33e6726dee20181958342c8197f76cd37818df67
  First bad revision: 052b086a834cd4d6722d6768d8f63b4785c140f2
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=33e6726dee20181958342c8197f76cd37818df67&tochange=052b086a834cd4d6722d6768d8f63b4785c140f2

Notes

• Attached a screenshot.
• The icons remains the same as in the screenshot after exiting Customize menu.

Comment 1

[Marco Castelluccio [:marco]]

Mike, can you take a look?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks! I've put this into the cleanup queue for triage and prioritization.

Comment 3

[Cieara Meador [:cmkm] (she/her)]

Attachment: Bug 1711844 - Correct customize menu icon colors. r?jhirsch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e85e8888096
Correct customize menu icon colors. r=jhirsch,desktop-theme-reviewers,dao

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2e85e8888096

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Seems like a pretty low-risk polish fix if we wanted to get it into the MR2 release. Please nominate the patch for Beta approval if you agree.

Comment 7

[Cieara Meador [:cmkm] (she/her)]

Comment on attachment 9244774 [details]
Bug 1711844 - Correct customize menu icon colors. r?jhirsch

Beta/Release Uplift Approval Request

• User impact if declined: Minor visual/style nit in customize menu regarding icon colors
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky as the bug and fix affect a styling inconsistency that doesn't impact usability
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244774 [details]
Bug 1711844 - Correct customize menu icon colors. r?jhirsch

Approved for 94.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4cb29abc2e31

Comment 10

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on Win 10x64 using an affected Nightly build 90.0a1 (2021-05-19), with STR from comment 0.

The issue is verified as fixed on latest Beta 94.0b5 and latest Nightly 95.0a1 under macOS 10.15, macOS 11 and Windows 10x64. All the icons have the same shade of grey. I could not reproduce this on Ubuntu 20.04.