1711848 - Add argument separation comments for QM_OR_ELSE(WARN|NOTE|LOG_VERBOSE)(_IF) uses

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

The complex uses of QM_TRY and QM_OR_ELSE are sometimes hard to read. Argument separation using comments should help with better readability.

Example:

QM_TRY(QM_OR_ELSE_WARN_IF(
    // Expression
    ToResult(InitializeOrigin(
        aPersistenceType, metadata,
        metadata.mLastAccessTime, metadata.mPersisted,
        childDirectory)),
    // Predicate
    IsDatabaseCorruptionError,
    // Fallback
    ([&childDirectory](
         const nsresult rv) -> Result<Ok, nsresult> {
      // If the origin can't be initialized due to
      // corruption, this is a permanent
      // condition, and we need to remove all data
      // for the origin on disk.

      QM_TRY(childDirectory->Remove(true));

      return Ok{};
    })));

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1711848 - Add argument separation comments for QM_OR_ELSE(WARN|NOTE|LOG_VERBOSE)(_IF) uses; r=#dom-storage

Depends on D115363

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5688acd04fa5
Add argument separation comments for QM_OR_ELSE(WARN|NOTE|LOG_VERBOSE)(_IF) uses; r=dom-storage-reviewers,jstutte

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5688acd04fa5