1711899 - The Sign in button should not be displayed on the Onboarding page when the `identity.fxaccounts.enabled` pref is set to false

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: sign in button shouldn't be displayed when sync is turned off.gif

[Affected versions]:

• Firefox Nightly 90.0a1, Build ID 20210518213628
• Firefox Beta 89.0b13, Build ID 20210516190025

[Affected Platforms]:

• Windows 10
• macOS 10.15
• Linux MX 4.19

[Prerequisites]:

• Have a new Firefox profile.
• Have the identity.fxaccounts.enabled pref set to false.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the about:welcome page and observe the top right corner of the page.

[Expected results]:

• Nothing is found.

[Actual results]:

• The Sign in link button is displayed, is actionable, but the Sync service is disabled.

[Notes]:

• The issue is also reproducible with a policies.json file or Windows GPO.
• Attached a screenshot of the issue.

Comment 1

[Ed Lee :Mardak]

This should also affect the new MR1 onboarding. Similar to bug 1710936 to follow the preference to decide to change what to show, we could remove the fxa link in prepareContentForReact?

Comment 2

[Punam Dahiya [:pdahiya]]

NI @ana to confirm its ok to hide SignIn link when sync pref is disabled, thanks

Comment 3

[Ed Lee :Mardak]

We wouldn't be able to sign in anyway, so pretty sure we shouldn't show the button. We can also remove the fxa metrics flow request too

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1711899 - Remove "Sign in" button and FxA metrics from about:welcome when FxA is disabled r?emcminn

Prepare content for both isProton and pre-proton designs. Also deep clone to avoid directly deleting from pre-proton DEFAULT object.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adceb058a4a1
Remove "Sign in" button and FxA metrics from about:welcome when FxA is disabled r=emcminn

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/adceb058a4a1

Comment 7

[Giorgia Nichita, Release Desktop QA]

Hello,

I have reproduced the issue using STR from comm 0, on an affected Nightly build 90.0a1 (2021-05-18)
I've verified the fix on 90.0b2 (2021-06-01). Tests were performed on Ubuntu 20.04, Windows 10 and macOs 10.15.

Thanks!