Closed Bug 1711912 Opened 3 years ago Closed 3 years ago

Implement QueryOutputProtectionStatus check in clearkey CDM

Categories

(Core :: Audio/Video: Playback, task, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: bryce, Assigned: bryce)

References

(Blocks 2 open bugs)

Details

Attachments

(6 files)

Bug 1711912 - Reorder ClearKeySessionManager include order. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1711912 - Move key system name constants into their own header. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1711912 - Set flag on clear key CDM if created using special protection query key system. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1711912 - Implement output protection query in Clearkey CDM. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1711912 - Add test case to ensure special key systems are only available if preffed on. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1711912 - Test we can access special protection query key system when preffed on. r?alwu
48 bytes, text/x-phabricator-request
Details | Review

If we implement functionality where the clearkey CDM calls back to the host using QueryOutputProtectionStatus and changes key status if the query is not serviced, this would let us expand our automated test coverage.

Fix this up before making further changes in later patches.

Move constants and fix up includes following doing so.

This is motivated by that future patches will want to use these constants in the
clear key CDM. If we don't move these constants and try to include the existing
VideoUtils in the clear key CDM this will break the build (because the clear key
CDM uses a restricted subset of the stuff we get in Gecko).

Depends on D122630

This lets the clear key CDM behave differently if it's created with the
protection query key system. The different behaviour will be implemented in
following patches and gated behind the member set here.

Depends on D122631

This implements logic in the clear key CDM to emulate protection queries. The
CDM will only do so if configured using the new test key system added prior to
this patch.

Depends on D122632

Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a2af5ba370f
Reorder ClearKeySessionManager include order. r=alwu
https://hg.mozilla.org/integration/autoland/rev/2aa33cd01f67
Move key system name constants into their own header. r=alwu
https://hg.mozilla.org/integration/autoland/rev/f6aeda8b4fca
Set flag on clear key CDM if created using special protection query key system. r=alwu
https://hg.mozilla.org/integration/autoland/rev/10639e1dbb6e
Implement output protection query in Clearkey CDM. r=alwu
https://hg.mozilla.org/integration/autoland/rev/db34f1ec3a86
Add test case to ensure special key systems are only available if preffed on. r=alwu
https://hg.mozilla.org/integration/autoland/rev/a3c678c2c608
Test we can access special protection query key system when preffed on. r=alwu

Backed out 6 changesets (Bug 1711912) for causing build bustages on MediaKeySystemAccessManager.cpp.
Backout link
Push with failures
Failure Log

Flags: needinfo?(bvandyk)

Thanks.

Looks like unified (edit: or rather, non-unified) build bustages due to changes to headers. Time to audit some includes.

Flags: needinfo?(bvandyk)
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b135eb6bb7db
Reorder ClearKeySessionManager include order. r=alwu
https://hg.mozilla.org/integration/autoland/rev/fde1d605fce1
Move key system name constants into their own header. r=alwu
https://hg.mozilla.org/integration/autoland/rev/b941cfb1f5ae
Set flag on clear key CDM if created using special protection query key system. r=alwu
https://hg.mozilla.org/integration/autoland/rev/964d14b3352e
Implement output protection query in Clearkey CDM. r=alwu
https://hg.mozilla.org/integration/autoland/rev/3e825fc0f7d3
Add test case to ensure special key systems are only available if preffed on. r=alwu
https://hg.mozilla.org/integration/autoland/rev/b07f45562c35
Test we can access special protection query key system when preffed on. r=alwu

Backed out 6 changesets (Bug 1711912) for causing build bustages on MediaKeySystemAccessManager.cpp.
Backout link
Push with failures
Failure Log

Flags: needinfo?(bvandyk)

I clearly did not have this as fixed as I thought. My bad.

Let's hope the third times the charm.

Pre landing non-unified build is green https://treeherder.mozilla.org/jobs?repo=try&revision=04ed2048df780926cd068049a00cf194407616a5

Let's try this again.

Flags: needinfo?(bvandyk)
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc32d906c76a
Reorder ClearKeySessionManager include order. r=alwu
https://hg.mozilla.org/integration/autoland/rev/0d4ae171202c
Move key system name constants into their own header. r=alwu
https://hg.mozilla.org/integration/autoland/rev/e03f4c9057b6
Set flag on clear key CDM if created using special protection query key system. r=alwu
https://hg.mozilla.org/integration/autoland/rev/e43b0926957e
Implement output protection query in Clearkey CDM. r=alwu
https://hg.mozilla.org/integration/autoland/rev/56daa01cdb37
Add test case to ensure special key systems are only available if preffed on. r=alwu
https://hg.mozilla.org/integration/autoland/rev/fab997a6b50d
Test we can access special protection query key system when preffed on. r=alwu
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: