Closed Bug 1711933 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29046 - Add tests to verify the layout shift score stay unchanged for touch drag

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29046 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29046
Details from upstream follow.

b'Lan Wei <lanwei@chromium.org>' wrote:

Add tests to verify the layout shift score stay unchanged for touch drag

Our current implementation in LayoutShiftTracker::NotifyInput puts all
the events after a Pointerdown event in a queue, and keep accumulating
the layout shift score, once we see a PointerUp, we set the PointerUp
event to be hasRecentInput, so the layout shift score will not increase
for this touch dragging case. But for touch scroll, we will send the
PointerCancel event instead, so the accumulating shift score will be
reported.

Bug: 1166952
Change-Id: Ia4b25d894b5787fdc7f244ab9a8006bc3ff69cff

Reviewed-on: https://chromium-review.googlesource.com/2898319
WPT-Export-Revision: e63a8057a6f76a9eb35be657d82cfbc13576dd93

CI Results

Ran 16 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/pointermove-becomes-drag.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] (Chrome: OK, Safari: OK)
No Shift in pointerdown reported when it becomes a touch drag.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/layout-instability/pointermove-becomes-drag.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe58b721dabc [wpt PR 29046] - Add tests to verify the layout shift score stay unchanged for touch drag, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.