1711997 - Take screenshot button is missing in context menu opened on a link element

Status: NEW

(Firefox :: Screenshots, defect, P3)

Description

[JB]

Attachment: RecApp-2021-05-20-00:25:42.mp4

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Do a right click on an element, that happens to be a link.

Actual results:

There's no "Take screenshot" button in the context menu (see screencast).

Expected results:

I should be able to take a screenshot of the element.

Comment 1

[JB]

The problem here is that the link element doesn't always look like a link (blue underlined text). In my example, it is impossible to say whether this block is a link, or plain div, or whatever.

It confuses me every time when I'm about to take screenshot of the page, but I cannot find the button in the context menu (because I've clicked on some <a> element that I don't even see).

Comment 2

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Screenshots' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Hi,
I am able to reproduce the issue in release 88, beta 89.0b14 and latest nightly 90.0a1 (2021-05-20) using Windows 10 and Ubuntu 20, but I am not sure if this an issue or this is the expected behavior. I will set this as New for visibility and waiting for the developers opinion about it. Also this is reproducible in Fx60 as well.

Thanks for your input.

Comment 4

[Emma Malysz]

Hey Meridel! Similar to bug 1679313, sfoster and I think "Take a screenshot" could be a useful item to have in the context menu when clicking on links. What position should we add it to?

Comment 5

[Meridel [:meridel]]

Hi Emma, since a screenshot can be taken from the page context menu, and then the image cropped to the link area, I am not clear on why we need to add Take Screenshot to the link context menu, too. I want to avoid adding multiple ways to do the same thing. Romain, thoughts on this?

Comment 6

[JB]

In modern web, link element does not usually look like plain blue underlined text. It can be a block/flex element of any size and style. It is impossible for user to tell whether the element is an <a> or any other element.

So how do user know what place on the page to click in order to make a screenshot?

For example, bugzilla.mozilla.org/home has 28 <a> elements, but I can see only 3 (for certain). It means that somewhere there are 25 areas of unknown size, which cannot be used to take a screenshot.

Comment 7

[Sam Foster [:sfoster] (he/him)]

I still think this is a valid bug. You could easily have a document where all the content is wrapped in an <a href> making it impossible to get anything other than the link context menu. However, its not specific to Screenshots. Ideally we'd have a neat, intuitive way of allowing the user to pick the "context" they intend. We see the same issue with <img>, <video> etc. - if those are z-indexed and sized to fill the viewport, its impossible to get the document context, you are stuck with whatever your pointer can click on.

Clearing ni? for :rtestard for now.