1712064 - security/manager/ssl/nsNSSComponent.cpp:2539:24: error: ?MakeScopeExit? was not declared in this scope

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Solaris build fails with:

19:56.73 In file included from Unified_cpp_security_manager_ssl2.cpp:29:
19:56.73 /builds/psumbera/mozilla-central-build/security/manager/ssl/nsNSSComponent.cpp: In function ?mozilla::UniqueCERTCertList mozilla::psm::FindClientCertificatesWithPrivateKeys()?:
19:56.73 /builds/psumbera/mozilla-central-build/security/manager/ssl/nsNSSComponent.cpp:2539:24: error: ?MakeScopeExit? was not declared in this scope
19:56.73  2539 |   auto exitTelemetry = MakeScopeExit([&] {
19:56.73       |                        ^~~~~~~~~~~~~

The first bad revision is:
changeset: 580105:4b4d4f52df08
user: Dana Keeler <[e-mail]>
date: Wed May 19 16:25:52 2021 -0700
description:
Bug 1711154 - collect telemetry on how long it takes to look for client auth certificates r=bbeurdouche data-review?chutten

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Security: PSM' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Petr Sumbera]

Attachment: Bug 1712064 - add missing ScopeExit header

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1711154

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f10854e202d8
add missing ScopeExit header r=keeler

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f10854e202d8

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9222771 [details]
Bug 1712064 - add missing ScopeExit header

Approved for the beta branch before 89 RC, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/46f7574c491c