1712231 - non-unified builds are not catching some errors

Status: RESOLVED DUPLICATE of bug 1725125

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Mike Hommey [:glandium]]

Bug 1712064 should have been caught at review time in bug 1711154, but two things prevented that from happening:

• the non-unified task didn't run on the reviewbot try (interestingly, the phabricator revision doesn't have a link to treeherder, but I found it manually here: https://treeherder.mozilla.org/jobs?repo=try&revision=40b6e1a15741aeb8db4f374431a21e7d0a3f7d05 and the non-unified task wasn't there until I triggered it manually)
• the non-unified task did run on landing (https://treeherder.mozilla.org/jobs?repo=autoland&revision=4b4d4f52df082864bbcc727b8bb37059d759876d&selectedTaskRun=QaZtQ_qORVSvbPokOElgmQ.0&searchStr=Linux%2Cx64%2Cdebug%2CC%2FC%2B%2B%2Cchecks%2Csource-test-clang-linux64-non-unified%2Cnon-unified) but didn't fail, and looking at the log, nsNSSComponent.cpp was never built.

Comment 1

[Andi [:andi]]

The non-unified task was not designed to be triggered by the bot. Bug 1725125 will fix the regression of the already fixed files for the non-unified system.