Closed Bug 1712401 Opened 3 years ago Closed 3 years ago

Double-check whether a chrome document can be out-of-process

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: botond, Unassigned)

References

Details

In bug 1699846, we identified this call site of nsPresContext::GetParentPresContext() as needing further investigation related to Fission.

The code in question is:

  nsPresContext* pc = /* ... */;     
  bool isChromeRootDoc =
    !pc->Document()->IsContentDocument() && !pc->GetParentPresContext();

where the intended interpretation of isChromeRootDoc is "this document is a chrome document and has no parent (or its parent is not a chrome document)".

Does this code remain correct in the presence of Fission?

I believe this boils down to, can chrome documents be out-of-process with Fission?

(In reply to Botond Ballo [:botond] from comment #0)

I believe this boils down to, can chrome documents be out-of-process with Fission?

Kashav, do you know the answer to this question, or could you route the question to someone who would? Thanks!

Flags: needinfo?(kmadan)

I'm fairly sure that chrome documents will never be out-of-process, but they can embed out-of-process frames. Forwarding to kmag who can confirm.

Flags: needinfo?(kmadan) → needinfo?(kmaglione+bmo)

Chrome BrowsingContexts can only exist in the parent process, so no.

Flags: needinfo?(kmaglione+bmo)

Thanks for the info! There's nothing to do here then.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.