1712401 - Double-check whether a chrome document can be out-of-process

Status: RESOLVED INVALID

(Core :: Panning and Zooming, defect)

Description

[Botond Ballo [:botond]]

In bug 1699846, we identified this call site of nsPresContext::GetParentPresContext() as needing further investigation related to Fission.

The code in question is:

  nsPresContext* pc = /* ... */;     
  bool isChromeRootDoc =
    !pc->Document()->IsContentDocument() && !pc->GetParentPresContext();

where the intended interpretation of isChromeRootDoc is "this document is a chrome document and has no parent (or its parent is not a chrome document)".

Does this code remain correct in the presence of Fission?

I believe this boils down to, can chrome documents be out-of-process with Fission?

Comment 1

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #0)

I believe this boils down to, can chrome documents be out-of-process with Fission?

Kashav, do you know the answer to this question, or could you route the question to someone who would? Thanks!

Comment 2

[u608768]

I'm fairly sure that chrome documents will never be out-of-process, but they can embed out-of-process frames. Forwarding to kmag who can confirm.

Comment 3

[Kris Maglione [:kmag]]

Chrome BrowsingContexts can only exist in the parent process, so no.

Comment 4

[Botond Ballo [:botond]]

Thanks for the info! There's nothing to do here then.