Closed Bug 1712419 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29081 - [GridNG] Synthesized baseline test updates

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29081 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29081
Details from upstream follow.

b'Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com>' wrote:

[GridNG] Synthesized baseline test updates

This change updates several CSS Grid alignment tests that were written
under the expectation that synthesized baselines could participate in
a baseline sharing group with vertical-RL aligned items.

The CSS alignment spec spec at
https://www.w3.org/TR/css-align-3/#baseline-export,
states "Otherwise, assume either horizontal-tb or vertical-lr
writing-mode, whichever is orthogonal to the box’s own writing-mode.",
which indicates that a synthesized baseline should not be assumed
to ever have vertical-rl alignment, and thus shouldn't be in a
baseline sharing group with other vertical-rl items, as these tests
were expecting.

This change also updates TestExpectations to move the SVG aspect
ratio tests that are currently marked as failing under GridNG to
their own section, as well as marking the CSS Grid align-content
tests as 'fail', so they are marked as failures under both grid
and GridNG.

Bug: 1045599
Change-Id: I052da46e1944c4b53eac15a11e9dadb09b669a27
Reviewed-on: https://chromium-review.googlesource.com/2911520
WPT-Export-Revision: 505c83803fb35df590618f03cc6c4bb4a3904eb6

PR 29081 applied with additional changes from upstream: 357197316b6a94f94409a7947f036c288c07405a
Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 24 subtests

Status Summary

Firefox

OK : 4
FAIL: 36

Chrome

OK : 4
PASS: 32
FAIL: 4

Safari

OK : 4
PASS: 32
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html
.grid 2: FAIL
.grid 3: FAIL
.grid 4: FAIL
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html
.grid 1: FAIL
.grid 3: FAIL
.grid 4: FAIL
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html
.grid 1: FAIL
.grid 3: FAIL
.grid 4: FAIL
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html
.inline-grid 1: FAIL linked bug:Bug 1712251
.inline-grid 2: FAIL linked bug:Bug 1712251
.inline-grid 3: FAIL linked bug:Bug 1712251
.inline-grid 4: FAIL linked bug:Bug 1712251
.inline-grid 5: FAIL linked bug:Bug 1712251
.inline-grid 6: FAIL linked bug:Bug 1712251
.inline-grid 7: FAIL linked bug:Bug 1712251
.inline-grid 8: FAIL linked bug:Bug 1712251
.inline-grid 9: FAIL linked bug:Bug 1712251
.inline-grid 10: FAIL linked bug:Bug 1712251
.inline-grid 11: FAIL linked bug:Bug 1712251
.inline-grid 12: FAIL linked bug:Bug 1712251
.inline-grid 13: FAIL linked bug:Bug 1712251
.inline-grid 14: FAIL linked bug:Bug 1712251
.inline-grid 15: FAIL linked bug:Bug 1712251
.inline-grid 16: FAIL linked bug:Bug 1712251
.inline-grid 17: FAIL linked bug:Bug 1712251
.inline-grid 18: FAIL linked bug:Bug 1712251
.inline-grid 19: FAIL linked bug:Bug 1712251
.inline-grid 20: FAIL linked bug:Bug 1712251
.inline-grid 21: FAIL linked bug:Bug 1712251
.inline-grid 22: FAIL linked bug:Bug 1712251
.inline-grid 23: FAIL linked bug:Bug 1712251

New Tests That Don't Pass

/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html
.grid 1: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 2: FAIL (Chrome: PASS, Safari: PASS)
.grid 3: FAIL (Chrome: PASS, Safari: PASS)
.grid 4: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html
.grid 1: FAIL (Chrome: PASS, Safari: PASS)
.grid 2: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 3: FAIL (Chrome: PASS, Safari: PASS)
.grid 4: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html
.grid 1: FAIL (Chrome: PASS, Safari: PASS)
.grid 2: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 3: FAIL (Chrome: PASS, Safari: PASS)
.grid 4: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html
.inline-grid 1: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 2: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 3: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 4: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 5: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 6: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 7: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 8: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 9: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 10: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 11: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 12: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 13: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 14: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 15: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 16: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 17: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 18: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 19: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 20: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 21: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 22: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 23: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 24: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e745fae1851f
[wpt PR 29081] - [GridNG] Synthesized baseline test updates, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf55d08a9fc4
[wpt PR 29081] - [GridNG] Synthesized baseline test updates, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0e67341503c
[wpt PR 29081] - [GridNG] Synthesized baseline test updates, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f0e67341503c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.