Closed Bug 1712509 Opened 3 years ago Closed 3 years ago

Preprocess static.js so CHATZILLA_VERSION can be used

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.8)

Attachments

(1 file, 1 obsolete file)

Rather than setting the cZ version in both moz.build and static.js, preprocess static.js so that it only needs to be set in moz.build

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9223137 - Flags: review?(frgrahl)
Attachment #9223137 - Flags: approval-comm-release?
Attachment #9223137 - Flags: approval-comm-esr60?

Properly qrefreshed

Attachment #9223137 - Attachment is obsolete: true
Attachment #9223137 - Flags: review?(frgrahl)
Attachment #9223137 - Flags: approval-comm-release?
Attachment #9223137 - Flags: approval-comm-esr60?
Attachment #9223138 - Flags: review?(frgrahl)
Attachment #9223138 - Flags: approval-comm-release?
Attachment #9223138 - Flags: approval-comm-esr60?

Comment on attachment 9223138 [details] [diff] [review]
1712509-irc-expand-czversion-2538.patch

LGTM

Attachment #9223138 - Flags: review?(frgrahl)
Attachment #9223138 - Flags: review+
Attachment #9223138 - Flags: approval-comm-release?
Attachment #9223138 - Flags: approval-comm-release+
Attachment #9223138 - Flags: approval-comm-esr60?
Attachment #9223138 - Flags: approval-comm-esr60+
Depends on: 1604663

Fixed for 2.53.8 beta first:
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/025b4fa5cd87a24d6aa9394d246b1958e8996462
Preprocess static.js so CHATZILLA_VERSION can be used. r=frg a=frg

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/a52c7c5b0e4e
Preprocess static.js so CHATZILLA_VERSION can be used. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.88
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: