1712535 - After opening contacts sidebar: Uncaught ReferenceError: ToolbarIconColor is not defined

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Thomas D. (:thomas8)]

90.0a1 (2021-05-20) (64-bit), Win10

Uncaught ReferenceError: ToolbarIconColor is not defined
OnLoadAddressBook chrome://messenger/content/addressbook/addressbook.js:143
<anonymous> chrome://messenger/content/addressbook/addressbook.js:65

Comment 1

[Richard Marti (:Paenglab)]

Looks like a regression from bug 1703164. Magnus, can you look if abContactsPanel.xhtml also needs this conversion or if it needs the addition of all the JS files like <script src="chrome://messenger/content/toolbarIconColor.js"/> etc?

I tried to add this file and the error goes away but then I get the an error about the following function AutoHideMenubar.init();

Comment 2

[Magnus Melin [:mkmelin]]

The contact sidebar shouldn't be loading addressbook.js to begin with. Some untangling will help.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1712535 - contacts sidebar shouldn't load addressbook.js. r=Paenglab

gPreviousDirTreeIndex was only used in SelectFirstAddressBook(), which is itself not used.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c1cded455c8
contacts sidebar shouldn't load addressbook.js. r=Paenglab