Closed Bug 1712564 Opened 5 years ago Closed 2 years ago

Intermittent leakcheck | tab 256 bytes leaked (HttpBackgroundChannelChild, HttpBackgroundChannelChild::ActorDestr, HttpBackgroundChannelChild::RecvOnTran, PHttpBackgroundChannelChild, nsStringBuffer)

Categories

(Core :: Networking: HTTP, defect, P5)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure, Whiteboard: [necko-triaged])

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=340613062&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AqbFn_dRQQSmREgqgucF4w/runs/0/artifacts/public/logs/live_backing.log


[task 2021-05-24T11:15:49.351Z] 11:15:49     INFO - TEST-PASS | leakcheck | tab no leaks detected!
[task 2021-05-24T11:15:49.352Z] 11:15:49     INFO - leakcheck | Processing leak log file /tmp/tmpbr2_shtm.mozrunner/runtests_leaks_tab_pid7121.log
[task 2021-05-24T11:15:49.353Z] 11:15:49     INFO - 
[task 2021-05-24T11:15:49.353Z] 11:15:49     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 7121
[task 2021-05-24T11:15:49.354Z] 11:15:49     INFO - 
[task 2021-05-24T11:15:49.355Z] 11:15:49     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
[task 2021-05-24T11:15:49.356Z] 11:15:49     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
[task 2021-05-24T11:15:49.356Z] 11:15:49     INFO -    0 |TOTAL                                 |       51      256|   12904        5|
[task 2021-05-24T11:15:49.357Z] 11:15:49     INFO -  113 |HttpBackgroundChannelChild            |      120      120|       1        1|
[task 2021-05-24T11:15:49.358Z] 11:15:49     INFO -  114 |HttpBackgroundChannelChild::ActorDestr|       40       40|       1        1|
[task 2021-05-24T11:15:49.359Z] 11:15:49     INFO -  117 |HttpBackgroundChannelChild::RecvOnTran|       40       40|       1        1|
[task 2021-05-24T11:15:49.360Z] 11:15:49     INFO -  241 |PHttpBackgroundChannelChild           |       48       48|       1        1|
[task 2021-05-24T11:15:49.360Z] 11:15:49     INFO -  551 |nsStringBuffer                        |        8        8|    7046        1|
[task 2021-05-24T11:15:49.361Z] 11:15:49     INFO - 
[task 2021-05-24T11:15:49.362Z] 11:15:49     INFO - nsTraceRefcnt::DumpStatistics: 615 entries
[task 2021-05-24T11:15:49.362Z] 11:15:49     INFO - TEST-INFO | leakcheck | tab leaked 1 HttpBackgroundChannelChild
[task 2021-05-24T11:15:49.363Z] 11:15:49     INFO - TEST-INFO | leakcheck | tab leaked 1 HttpBackgroundChannelChild::ActorDestr
[task 2021-05-24T11:15:49.364Z] 11:15:49     INFO - TEST-INFO | leakcheck | tab leaked 1 HttpBackgroundChannelChild::RecvOnTran
[task 2021-05-24T11:15:49.364Z] 11:15:49     INFO - TEST-INFO | leakcheck | tab leaked 1 PHttpBackgroundChannelChild
[task 2021-05-24T11:15:49.365Z] 11:15:49     INFO - TEST-INFO | leakcheck | tab leaked 1 nsStringBuffer
[task 2021-05-24T11:15:49.366Z] 11:15:49     INFO - TEST-UNEXPECTED-FAIL | leakcheck | tab 256 bytes leaked (HttpBackgroundChannelChild, HttpBackgroundChannelChild::ActorDestr, HttpBackgroundChannelChild::RecvOnTran, PHttpBackgroundChannelChild, nsStringBuffer)
[task 2021-05-24T11:15:49.366Z] 11:15:49     INFO - 
[task 2021-05-24T11:15:49.367Z] 11:15:49     INFO - leakcheck | Processing leak log file /tmp/tmpbr2_shtm.mozrunner/runtests_leaks_tab_pid5775.log
[task 2021-05-24T11:15:49.368Z] 11:15:49     INFO - 
[task 2021-05-24T11:15:49.368Z] 11:15:49     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 5775
[task 2021-05-24T11:15:49.369Z] 11:15:49     INFO - 
[task 2021-05-24T11:15:49.370Z] 11:15:49     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
[task 2021-05-24T11:15:49.370Z] 11:15:49     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
[task 2021-05-24T11:15:49.371Z] 11:15:49     INFO -    0 |TOTAL                                 |       53        0|  105274        0|
[task 2021-05-24T11:15:49.372Z] 11:15:49     INFO - 
[task 2021-05-24T11:15:49.372Z] 11:15:49     INFO - nsTraceRefcnt::DumpStatistics: 762 entries
[task 2021-05-24T11:15:49.373Z] 11:15:49     INFO - TEST-PASS | leakcheck | tab no leaks detected!```
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

The latest failure looks to be happening while running browser/base/content/test/protectionsUI/, which is interesting given that that's the component this bug was filed in, but the underlying issue being triggered by the test is probably in Networking.

Component: Protections UI → Networking: HTTP
Product: Firefox → Core

In the two most recent failures, the process that leaked was created while running browser/base/content/test/protectionsUI/browser_protectionsUI_socialtracking.js. If somebody wants to investigate this, maybe a first step would be to look at the test and see if it is doing anything odd. It is neither the first nor the last test run in that directory.

Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

It seems we are leaking the runnable here:
https://searchfox.org/mozilla-central/rev/f030995a79461379153293c0e07f4982afe9ac28/netwerk/protocol/http/HttpBackgroundChannelChild.cpp#479

"HttpBackgroundChannelChild::ActorDestroy", [self]() {

The runnables get cleared in either onstartrequest or onChannelClosed.
So I assume what's happening is that we process HttpChannelChild::ActorDestroy, we then process an IPC message that queues another runnable, then [HttpBackgroundChannelChild::ActorDestroy}(https://searchfox.org/mozilla-central/rev/f030995a79461379153293c0e07f4982afe9ac28/netwerk/protocol/http/HttpBackgroundChannelChild.cpp#478).

Not sure exactly if that's actually possible, but this seems not super critical.

Status: REOPENED → NEW
Whiteboard: [necko-triaged]
Status: NEW → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.