Closed
Bug 1712586
Opened 3 years ago
Closed 3 years ago
Fix browser_harautomation_simple.js still failing with server side target switching
Categories
(DevTools :: Netmonitor, enhancement)
DevTools
Netmonitor
Tracking
(Fission Milestone:M8, firefox91 fixed)
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
Followup for bug 1709792,
browser_harautomation_simple.js still fails with devtools.target-switching.server.enabled=true.
Listening to will-navigate on the target front is still subject to race condition.
The listener set onto the target front may come late and miss it.
And the server may emit the event while the target is being destroyed and we would also miss it.
In https://phabricator.services.mozilla.com/D114464, I tried to workaround that, but it was causing some other test failure in source map related tests.
We would better introduce a DOCUMENT_EVENT's will-navigate event, which wouldn' suffer from such race condition.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Fission Milestone: --- → M8
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
|
||
Updated•3 years ago
|
Assignee: nobody → poirot.alex
Attachment #9223227 -
Attachment description: Bug 1712586 - Use DOCUMENT_EVENT's will-navigate in HAR automation. → Bug 1712586 - [devtools] Use DOCUMENT_EVENT's will-navigate in HAR automation.
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb5cc55fc778 [devtools] Use DOCUMENT_EVENT's will-navigate in HAR automation. r=bomsy
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•