Closed Bug 1712602 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 29091 - cancelScheduledValues throws RangeError for negative values

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29091 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29091
Details from upstream follow.

b'Raymond Toy <rtoy@chromium.org>' wrote:

cancelScheduledValues throws RangeError for negative values

The spec clearly states that cancelScheduledValues must throw a
RangeError for negative values. Make it so, and add a test for this.
We also add tests for NaN and Infinity.

Note, however, that the spec says RangeError is also thrown for
non-finite values. This is incorrect since cancelTime is a double,
not unrestricted double. (See
https://github.com/WebAudio/web-audio-api-v2/issues/127)

Thus, the test throws TypeError for NaN and Infinity.

Bug: 1212307
Change-Id: I750ab0f2b9f17f94d04cb2e9422b4f626252dfbc
Reviewed-on: https://chromium-review.googlesource.com/2909615
WPT-Export-Revision: 38a74330343613a5dde949548575094c3aa12baa

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 35 subtests

Status Summary

Firefox

OK : 1
PASS: 18
FAIL: 5

Chrome

OK : 1
PASS: 20
FAIL: 3

Safari

OK : 1
PASS: 23

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values.html
X gain.gain.setValueAtTime(3, 0.375) incorrectly threw NotSupportedError: "AudioParam.setValueAtTime: Can't add events during a curve event".: FAIL
X output[2000:2999]: Expected 1.5 for all values but found 1000 unexpected values:
Index Actual
[0] 1
[1] 0.9990000128746033
[2] 0.9980000257492065
[3] 0.996999979019165
...and 996 more errors.: FAIL
X output[3000:]: Expected 3 for all values but found 5000 unexpected values:
Index Actual
[0] 0
[1] -0.0010000000474974513
[2] -0.0020000000949949026
[3] -0.003000000026077032
...and 4996 more errors.: FAIL
< [cancel1] 3 out of 11 assertions were failed.: FAIL

AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed.: FAIL (Chrome: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a189a902c2c0 [wpt PR 29091] - cancelScheduledValues throws RangeError for negative values, a=testonly https://hg.mozilla.org/integration/autoland/rev/527d6829c216 [wpt PR 29091] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05b528071d06 [wpt PR 29091] - cancelScheduledValues throws RangeError for negative values, a=testonly https://hg.mozilla.org/integration/autoland/rev/7f313841f706 [wpt PR 29091] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57564ff1d44f [wpt PR 29091] - cancelScheduledValues throws RangeError for negative values, a=testonly https://hg.mozilla.org/integration/autoland/rev/cef4d6b541e5 [wpt PR 29091] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/57564ff1d44f
https://hg.mozilla.org/mozilla-central/rev/cef4d6b541e5

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.