Closed Bug 1712608 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29092 - Update test and move cancelAndHold test to WPT

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29092 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29092
Details from upstream follow.

b'Raymond Toy <rtoy@chromium.org>' wrote:

Update test and move cancelAndHold test to WPT

First add tests to cancelAndHoldAtTime for negative and non-finite
values to verify that the correct error is thrown.

Second, move the test to WPT. Manually verified that Safari passes
this test. Firefox fails because it doesn't have cancelAndHoldAtTime
yet.

Bug: 1212672
Change-Id: I0c2efdc0deacc6e1d12caa17d6993bd99fccb709
Reviewed-on: https://chromium-review.googlesource.com/2912306
WPT-Export-Revision: 4ca368954789d98f870c4601443fa9e6cbe2a863

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 114 subtests

Status Summary

Firefox

OK : 1
PASS: 22
FAIL: 19

Chrome

OK : 1
PASS: 106

Safari

OK : 1
PASS: 106

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold.html
Executing "linear": FAIL
Executing "exponential": FAIL
Executing "setTarget": FAIL
Executing "setValueCurve": FAIL
Executing "setValueCurve after end": FAIL
Executing "initial setTarget": FAIL
Executing "post cancel: Linear": FAIL
Executing "post cancel: Exponential": FAIL
Executing "post cancel: ValueCurve": FAIL
Executing "post cancel: setTarget": FAIL
Executing "post cancel: setValue": FAIL
Executing "cancel future setTarget": FAIL
Executing "cancel setTarget now": FAIL
Executing "cancel future setValueCurve": FAIL
Executing "cancel setValueCurve now": FAIL
Executing "linear, cancel, linear, cancel, linear": FAIL

New Tests That Don't Pass

/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold.html
Executing "linear": FAIL (Chrome: PASS, Safari: PASS)
Executing "exponential": FAIL (Chrome: PASS, Safari: PASS)
Executing "setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "setValueCurve": FAIL (Chrome: PASS, Safari: PASS)
Executing "setValueCurve after end": FAIL (Chrome: PASS, Safari: PASS)
Executing "initial setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: Linear": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: Exponential": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: ValueCurve": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: setValue": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel future setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel setTarget now": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel future setValueCurve": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel setValueCurve now": FAIL (Chrome: PASS, Safari: PASS)
Executing "linear, cancel, linear, cancel, linear": FAIL (Chrome: PASS, Safari: PASS)
X cancelAndHoldAtTime(-1) threw "TypeError" instead of EcmaScript error RangeError.: FAIL
< [cancelTime] 1 out of 3 assertions were failed.: FAIL

AUDIT TASK RUNNER FINISHED: 1 out of 17 tasks were failed.: FAIL

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7653439a986f
[wpt PR 29092] - Update test and move cancelAndHold test to WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d66d655ef1f5
[wpt PR 29092] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/844ad162d8f5
[wpt PR 29092] - Update test and move cancelAndHold test to WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4a694007cc5c
[wpt PR 29092] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/237f347ea77a
[wpt PR 29092] - Update test and move cancelAndHold test to WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/04efbd3bf8de
[wpt PR 29092] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/237f347ea77a
https://hg.mozilla.org/mozilla-central/rev/04efbd3bf8de

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.