1712618 - checkbox for bookmarks dialog "show editor when saving" does not get proper focus indicator in Windows high contrast mode

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Asa Dotzler [:asa]]

When tabbing to the "Show editor when saving" checkbox in the Bookmarks panel when in WIndows High Contrast Mode, there is no focus outline.

Steps:

1. Enable Windows High Contrast Black theme (HCM)
2. Open Firefox Nightly
3. Ctrl+L to focus addressbar
4. Ctrl+tab to focus bookmark star
5. Space to activate Bookmarks panel
6. Tab 5 times to checkbox

Results: not obvious checkbox is focused because no focus indicator
Expected: a focus ring around the checkbox
Other: after some playing around with the dialog, not sure what, I was once able to get the checkbox to show a focus indicator.

Comment 1

[Shaoting Huang]

1. several of us cannot replicate the problem currently on win10, can you replicate it now, and how:
2. Did you mean it for crtl Tab right after crtl L?
   Thanks

Comment 2

[Morgan Reschenberg [:morgan]]

(In reply to Shaoting Huang from comment #1)

1. several of us cannot replicate the problem currently on win10, can you replicate it now, and how:
2. Did you mean it for crtl Tab right after crtl L?
   Thanks

I think Asa meant 'tab' not control tab, I can reproduce that way:

Enable Windows High Contrast Black theme (HCM)
Open Firefox Nightly
Ctrl+L to focus addressbar
Tab to focus bookmark star
Space to activate Bookmarks panel
Tab 5 times to checkbox

Comment 3

[Shaoting Huang]

I did the same, but the highlight focus box is still there no matter how many times I have tried... is this platform specific maybe the windows version?
Im using:Edition Windows 10 Pro
Version 21H1
Installed on ‎6/‎29/‎2021
OS build 19043.1237
Experience Windows Feature Experience Pack 120.2212.3530.0

and enabled black HCM on win10s, current central nightly build and not single settings changed.

Anymore details on maybe your enviroment?

also not sure if this is related im using ryzen platform cpu instead of intel (which I don't think is related)

For me or Molly mhowell @mhowell:mozilla.org or Micah mtigley @mtigley:mozilla.org, we all weren't able to reproduce this symptom

Comment 4

[Morgan Reschenberg [:morgan]]

(In reply to Shaoting Huang from comment #3)

I did the same, but the highlight focus box is still there no matter how many times I have tried... is this platform specific maybe the windows version?
Im using:Edition Windows 10 Pro
Version 21H1
Installed on ‎6/‎29/‎2021
OS build 19043.1237
Experience Windows Feature Experience Pack 120.2212.3530.0

and enabled black HCM on win10s, current central nightly build and not single settings changed.

Anymore details on maybe your enviroment?

also not sure if this is related im using ryzen platform cpu instead of intel (which I don't think is related)

For me or Molly mhowell @mhowell:mozilla.org or Micah mtigley @mtigley:mozilla.org, we all weren't able to reproduce this symptom

Ah sorry I was testing in release, looks like its fixed in nightly for the checkbox but now the 'save' button doesn't have a focus indicator. Can you reproduce that?

Comment 5

[Shaoting Huang]

I do have them all for some reason..

Comment 6

[Shaoting Huang]

I still cannot replicate that as well, the save button has the focus ring as well, is there anything i'm missing?

Comment 7

[Morgan Reschenberg [:morgan]]

(In reply to Shaoting Huang from comment #6)

I still cannot replicate that as well, the save button has the focus ring as well, is there anything i'm missing?

Huh. I'm not sure. My STR are:

1. In Windows 'ease of access' settings, enable high contrast mode with theme 'high contrast black'
2. Open firefox nightly
3. Verify 'use system colors' is checked in about:preferences, and that the dropdown is set to 'only with high contrast themes' (these are the defaults, but I check just to make sure
4. Visit a site (doesn't matter if it was bookmarked previously)
5. Press ctrl + L to focus the address bar, tab once, arrow to bookmarks icon
6. Activate the bookmarks icon with the spacebar.
7. Hit tab several times until the 'save' button (should be) focused

I'm running windows 10 (settings says version 20H2, if that's helpful)

I see every other control (including the remove button) get a focus outline, but not the save button

Comment 8

[Micah [:mtigley] (she/her)]

This seems to reproduce for me if I have the "High Contrast White" theme selected on Windows 10. I'm able to see focus outlines for every control except the "save" button, which Morgan mentioned above.

My config:

• High Contrast is enabled on Windows 10 with High Contrast White selected
• From about:preferences, ensure that "Use system colors" is checked and that "Only with High Contrast themes" or "Always" is selected
• From about:addons under "Themes", make sure you have "System theme" is enabled (the above step should already take care of this, but just in case)

Edit: .gif of what I'm observing below

Comment 9

[Micah [:mtigley] (she/her)]

Attachment: Focus outline not visible on "Save" button when HCM white theme is enabled

Comment 10

[Itiel]

Adding --focus-outline-color: var(--button-primary-bgcolor) to this rule:
https://searchfox.org/mozilla-central/rev/d10188f9b4f1c4974264f3925505a0498d346c57/toolkit/themes/shared/popupnotification.inc.css#160
should fix it.

Comment 11

[Shaoting Huang]

Attachment: Bug 1712618 - bookmarks dialog "show editor when saving" checkbox does not get proper focus indicator in Windows high contrast mode

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6591695e856a
bookmarks dialog "show editor when saving" checkbox does not get proper focus indicator in Windows high contrast mode r=desktop-theme-reviewers,dao

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6591695e856a

Comment 14

[Mark Banner (:standard8)]

Dropping what looks like a now-unnecessary needinfo request.

Comment 15

[Giorgia Nichita, Release Desktop QA]

Reproduced this on an affected Nightly build 95.0a1 (20210524215832) on Win 10x64.

Verified as fixed on Beta 95.0b3 (20211104185958), Win 10x64.