[wpt-sync] Sync PR 29096 - [css-fonts] Avoid SECURITY_DCHECK failure with system font in animations
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
526.43 KB,
text/plain
|
Details |
Sync web-platform-tests PR 29096 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/29096
Details from upstream follow.
b'Oriol Brufau <obrufau@igalia.com>' wrote:
[css-fonts] Avoid SECURITY_DCHECK failure with system font in animations
r885715 added CSSPendingSystemFontValue in order to handle system fonts
at parse time, deferring the resolution until computed-value time.The problem was that animations weren't using StyleBuilderConverter, so
these CSSPendingSystemFontValue would remain unresolved in e.g.element.animate([{"font":"icon"}], {"duration": 1000});
Therefore, this patch makes CSSFontStretchInterpolationType and
CSSFontWeightInterpolationType use StyleBuilderConverter, just like
CSSFontVariationSettingsInterpolationType was already doing.Bug: 1212321
TEST=external/wpt/css/css-fonts/animations/system-fonts.html
Some checks fail because the font-size of a system font interpolates
discretely. Worked well before r885715, I will fix it in a follow-up.Change-Id: Ic20664cc7103c3f0a1fc6f7bb97a988f9326aa04
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/2915713
WPT-Export-Revision: 31c306d0645050641f46f434837a59e37cf6a320
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=199cf69b6f8b8f768f2b07fdc5d33f6b230c27f4
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 178 tests and 168 subtests ## Status Summary ### Firefox OK : 178 PASS: 21963 FAIL: 2587 ### Chrome OK : 178 PASS: 23210 FAIL: 1340 ### Safari OK : 178 PASS: 16626 FAIL: 7924 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=81d5e39f2890162d608cb3f267c870f1d05bb6f7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=81d5e39f2890162d608cb3f267c870f1d05bb6f7&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7620678b13b [wpt PR 29096] - [css-fonts] Avoid SECURITY_DCHECK failure with system font in animations, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be2940149f55 [wpt PR 29096] - [css-fonts] Avoid SECURITY_DCHECK failure with system font in animations, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df366c9db417 [wpt PR 29096] - [css-fonts] Avoid SECURITY_DCHECK failure with system font in animations, a=testonly
Comment 6•3 years ago
|
||
bugherder |
Description
•