1712686 - Pull DevToolsClient from `commands` instead of target fronts

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Various code currently fetch the DevToolsClient via the target fronts, but it is imperfect for two reasons:

• because of target switching, the target may be destroyed and replaced by another one. While the target is short lived, the client will still be available. So we should host the client on something that is having the same or longer lifetime as itself. commands is having a similar lifetime to its inner DevtoolsClient.
• it forces us to fetch and use a target front, whereas you may want to use a client without having any target offhand. commands is again is good host as it is the first available object to spawn before doing any RDP interaction.

Also, some usages of DevToolsClient (typically waitForRequestToSettle) should ideally be refactored to stop using DevToolsClient directly and instead go through a TestCommand (bug 1701602).
So that frontend codebase never use RDP directly and only use commands.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1712686 - [devtools] Pull DevToolsClient from commands object instead of target fronts.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb760390b045
[devtools] Pull DevToolsClient from commands object instead of target fronts. r=nchevobbe

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cb760390b045