1712720 - Penultimate PropertyDescriptor cleanup

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1712720 - Assert hasConfigurable and hasEnumerable in assertComplete. r?jandem

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1712720 - Don't allow adding getters or setters to data-descriptors. r?jandem

Depends on D115878

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1712720 - Remove PropertyDescriptor hasGetterOrSetter. r?jandem

Using isAccessorDescriptor is actually a very minor behavior change,
because this also applies to {get: undefined, set: undefined}.

Depends on D115879

Comment 4

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1712720 - Remove JSPROP_IGNORE_*. r?jandem

Depends on D115880

Comment 5

[Tom S. (please needinfo tschuster)]

The try run isn't finished yet, but it's probably fine: https://treeherder.mozilla.org/jobs?repo=try&revision=e659bd0df17eefd43f386b115054b79b78706fc0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29532272e690
Assert hasConfigurable and hasEnumerable in assertComplete. r=jandem
https://hg.mozilla.org/integration/autoland/rev/379c3a49ac6d
Don't allow adding getters or setters to data-descriptors. r=jandem
https://hg.mozilla.org/integration/autoland/rev/2a6fdc5ec9e2
Remove PropertyDescriptor hasGetterOrSetter. r=jandem
https://hg.mozilla.org/integration/autoland/rev/59444246768c
Remove JSPROP_IGNORE_*. r=jandem

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/29532272e690
https://hg.mozilla.org/mozilla-central/rev/379c3a49ac6d
https://hg.mozilla.org/mozilla-central/rev/2a6fdc5ec9e2
https://hg.mozilla.org/mozilla-central/rev/59444246768c