1712745 - Make browser/components/extensions/test/browser/browser_ext_tabs_readerMode.js work with Fission and BFCache

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

So what's going on is that these two lines of code: https://searchfox.org/mozilla-central/rev/202250ee5931648185c8abb3061d738b15b64067/docshell/base/nsDocShell.cpp#1224-1225 are causing two onStateChange notifications, and the later one cause an extra tabUpdated message here: https://searchfox.org/mozilla-central/rev/202250ee5931648185c8abb3061d738b15b64067/browser/components/extensions/test/browser/browser_ext_tabs_readerMode.js#68

When the document comes from the bfcache we get:

• onLocationChange() with isLoadingDocument = false
• onStateChange() with isLoadingDocument = true (from the first line)
• onStateChange() with isLoadingDocument = false (from the second one)

So the test sees the later one and triggers an extra tabUpdated message, then proceeds while it thinks it has a different page loaded and it all goes downhill from there.

Olli, Is the order of notifications above expected? If so, I can just fix the test to wait for the right URL. If not, I can look into fixing that.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

(+peter in case he has the nsIWebProgress notification order more fresh).

In any case, no rush. I need to go for the day now, but I'll double-check the notification order with the old bfcache. There's a chance that the test is using the new bfcache but with fission disabled it's not using the bfcache at all (in which case if the notification order matches then we can probably just fix the test).

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1712745 - Wait for the right tab update in browser_ext_tabs_readerMode.js. r=smaug!,robwu!

In the case of bfcache because the location change in that case comes
with a "complete" state, which confuses the test.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I guess the question is that what notifications we get in the old bfcache.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1712745 - Fix notification order when coming out of the bfcache. r=smaug

So that the location change doesn't appear to happen on an
already-loaded document. This matches the old bfcache.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ba1ab810f7c
Fix notification order when coming out of the bfcache. r=smaug

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4ba1ab810f7c