Closed Bug 1712764 Opened 7 months ago Closed 6 months ago

Use js::EnumFlags for shape property attributes

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

After Tom's PropertyDescriptor cleanup (bug 1700958) we can now easily move away from the JSPROP_* flags for property attributes stored in shapes.

Changing from uint8_t/unsigned to a strongly typed class also makes the code more robust and easier to understand which is nice for the ReShape work in bug 1704430.

Depends on: 1700958

This flag isn't used by the shape code.

This improves type safety end gets rid of manual flag checks (with bit masking) in
a number of places.

"flags" is used instead of "attributes" because it's shorter and elsewhere we use
attributes for just the configurable/enumerable/writable bits.

Depends on D115911

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18e1d83ff757
part 1 - Stop setting JSPROP_RESOLVING in ComputeAttributes. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/d4c270e6faf7
part 2 - Add ShapePropertyFlags and use for ShapeProperty and Shape. r=evilpie
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Blocks: 1713083
You need to log in before you can comment on or make changes to this bug.