1712764 - Use js::EnumFlags for shape property attributes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

After Tom's PropertyDescriptor cleanup (bug 1700958) we can now easily move away from the JSPROP_* flags for property attributes stored in shapes.

Changing from uint8_t/unsigned to a strongly typed class also makes the code more robust and easier to understand which is nice for the ReShape work in bug 1704430.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1712764 part 1 - Stop setting JSPROP_RESOLVING in ComputeAttributes. r?evilpie!

This flag isn't used by the shape code.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1712764 part 2 - Add ShapePropertyFlags and use for ShapeProperty and Shape. r?evilpie!

This improves type safety end gets rid of manual flag checks (with bit masking) in
a number of places.

"flags" is used instead of "attributes" because it's shorter and elsewhere we use
attributes for just the configurable/enumerable/writable bits.

Depends on D115911

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18e1d83ff757
part 1 - Stop setting JSPROP_RESOLVING in ComputeAttributes. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/d4c270e6faf7
part 2 - Add ShapePropertyFlags and use for ShapeProperty and Shape. r=evilpie

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/18e1d83ff757
https://hg.mozilla.org/mozilla-central/rev/d4c270e6faf7