1712775 - [Proton] One Off Area alignment issues

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Mehmet]

Attachment: Text-Label_Actual_vs_Expected.png

Nightly 90.0a1 (2021-05-25) (64-Bit)
macOS 11.4

Issue 1.) Take a look at the position of the "This time, search with" text label.
Issue 2.) Make the window small, so that the One Off buttons move below the text label.

Actual: Text label and One Off buttons are not aligned with the favicons above.

Expected: Text label could be moved by 3 px to the left and One Off buttons could be moved 6 px to the left to be aligned with the favicons above.

Screenshots are attached.

Thanks.

Comment 1

[Mehmet]

Attachment: One-Off-Buutons_Actual_vs_Expected_2.png

• further screenshot

Comment 2

[Harry Twyford]

Attachment: Bug 1712775 - Align one-off items with Urlbar icons. r?daisuke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5db9b19863ea
Align one-off items with Urlbar icons. r=daisuke

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5db9b19863ea

Comment 5

[Mehmet]

Attachment: Verified_after_fix.png

Perfect, thanks! Looks as expected in Nightly 91.0a1 (2021-06-02) (64-Bit) on macOS 11.4 .

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Harry Twyford]

Uplift not needed. This also exists in other versions back to when we introduced the new look of the one-offs, which was many versions ago. This can ride the trains.

Comment 8

[Gabi Cheta [:Gabi] Desktop QA]

Verified issues as fixed with Fx 91.0a1 on Windows 10x64, Ubuntu 16.4 and macOS 10.12.6.