Closed Bug 1712802 Opened 21 days ago Closed 18 days ago

Show Pin or Default or Start about:welcome with appropriate headline + button and no helper image

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
90 Branch
Iteration:
90.3 - May 17 - May 30
Tracking Status
firefox90 --- fixed

People

(Reporter: Mardak, Assigned: pdahiya)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-onboarding][priority:2b])

Attachments

(2 files)

If Firefox can be pinned and not pinned, about:welcome should show "Pin Firefox to your taskbar for easy access" with "Pin to taskbar" button. If also needs default, additional screen "Make Firefox your default" "Put speed, safety, and privacy on autopulot." "Make default browser"

If not default then "Welcome to Firefox" and "Make Firefox my default browser"

Otherwise "Get started" and without "Not now"

https://www.figma.com/file/0awIRES0ZvRJ1U89fYPXjQ/MR1-Onboarding?node-id=2539%3A38658

See Also: → 1699842
See Also: → 1710936
See Also: → 1701873
Assignee: nobody → pdahiya
Status: NEW → ASSIGNED

Bug 1699842 moves has AboutWelcomeChild updating featureConfig with .needPin as it's not available from content process. Similarly default browser check needs to be passed along reusing this pattern.

Depends on: 1699842

Make the default screens show pin then default then import then theme. Detect if the pin screen should be default or start and remove the 2nd screen default if necessary.

Depends on D116185

Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/943f7989c46e
New User Onboarding string updates r=fluent-reviewers,flod
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1bb1cb8c82ff
Show Pin or Default or Start about:welcome with appropriate headline + button and no helper image r=pdahiya
See Also: → 1713382
Status: ASSIGNED → RESOLVED
Closed: 18 days ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
See Also: → 1699852

I have verified that "about:welcome" page for new users is correctly displayed according to Figma using Firefox Beta 90.0b2 (Build ID: 20210601190019) on Windows 10 x64 20H2.

I have also verified the following using Firefox Beta 90.0b2 (Build ID: 20210601190019) on macOS 13.1:

  • If Firefox is not marked as "Keep in Dock" and it is not set as default browser, the following pages are displayed:

    • 1st page: respects the fonts, colors, and strings from Figma and the primary button is "Keep in Dock".
    • 2nd page, 1st modal: respects the fonts, colors, and strings from Figma and the primary button is "Make default browser".
    • 2nd page, 2nd modal: respects the fonts, colors, and strings from Figma and the primary button is "Import from previous browser".
    • 2nd page, 3rd modal: respects the fonts, colors, and strings from Figma and the primary button is "Save theme".
  • If Firefox is not marked as "Keep in Dock" and it is set as default browser, the following pages are displayed:

    • 1st page: respects the fonts, colors, and strings from Figma and the primary button is "Keep in Dock".
    • 2nd page, 1st modal: respects the fonts, colors, and strings from Figma and the primary button is "Import from previous browser".
    • 2nd page, 2nd modal: respects the fonts, colors, and strings from Figma and the primary button is "Save theme".
  • If Firefox is marked as "Keep in Dock" and it is set as default browser, the following pages are displayed:

    • 1st page: respects the fonts, colors, and strings from Figma, the primary button is "Get started" and the "Not now" secondary button is not displayed.
    • 2nd page, 1st modal: respects the fonts, colors, and strings from Figma and the primary button is "Import from previous browser".
    • 2nd page, 2nd modal: respects the fonts, colors, and strings from Figma and the primary button is "Save theme".

That being said, I've noticed that there is a discrepancy between Figma and the displayed modals. The difference is that there is a space between the modal header title + subtitle and the primary button which was introduced with bug 1706478. @Punam, can you please confirm which one is expected to be displayed?

Flags: needinfo?(pdahiya)
See Also: → 1714148

@romartin bug 1706478 fix tried to keep container height same on all steps which introduced spacing seen between subtitle and primary button. My take our figma should be updated to reflect that. NI @rcasey to confirm space seen on about:welcome Import screen between subtitle and primary button is expected. Thanks

Flags: needinfo?(pdahiya) → needinfo?(rcasey)

apologies, @punam - I was out last week. I will confirm with the UX team today with an answer.

Flags: needinfo?(rcasey)

Ideally the spacing between the subtitle and primary button should match the figma comp. I understand the fix to address the consistent container size, but if it's possible to update we would prefer the figma spacing over the current about: welcome Import screen. Thanks!

You need to log in before you can comment on or make changes to this bug.