1712803 - Ensure external surface lifetimes match that of their referencing blob

Status: NEW

(Core :: Graphics: WebRender, defect, P3)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1712803 - Ensure external surface lifetimes match that of their referencing blob.

Prior to this patch, blob images would ensure external surfaces live as
long as the recording by keeping strong references to the surfaces in
the content process, attached to each relevant display item. This was
prone to the content process releasing the surfaces (because the display
item is gone) before the rasterization of the blob image. The external
surface may be missing, and it would crash the compositor process.

Now we tell the compositor process about the dependencies the blob
recording has on external surfaces. It is responsible for keeping the
surfaces alive until the last epoch passes from which they could have
been used.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1712803 - Ensure external surface lifetimes match that of their referencing blob.

Prior to this patch, blob images would ensure external surfaces live as
long as the recording by keeping strong references to the surfaces in
the content process, attached to each relevant display item. This was
prone to the content process releasing the surfaces (because the display
item is gone) before the rasterization of the blob image. The external
surface may be missing, and it would crash the compositor process.

Now we tell the compositor process about the dependencies the blob
recording has on external surfaces. It is responsible for keeping the
surfaces alive until the last epoch passes from which they could have
been used.

Comment 3

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aosmond, could you have a look please?
For more information, please visit auto_nag documentation.