Closed Bug 1712826 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29106 - [GridNG] Updating grid-baseline-align-cycles-001.html

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29106 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29106
Details from upstream follow.

b'Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com>' wrote:

[GridNG] Updating grid-baseline-align-cycles-001.html

This CL updates this test to match expectations where baseline
alignment should not apply. The CSS Grid spec indicates that baseline
alignment should not apply in cases where there's a cyclic dependency
on sizing in the dimension where baseline alignment applies. However,
it also states that certain conditions will force another sizing pass,
and under such conditions baseline alignment may be possible, and under
these circumstances, baseline alignment should apply. If we were to
change behavior to match this test case, numerous other second pass
baseline tests would break. In fact, this test was actually matching
the old expected results before we added logic to support second
passes on baseline alignment - see
https://chromium-review.googlesource.com/c/chromium/src/+/2873217.

Instead, this change updates the test expectations so that they are
all situations where baseline alignment should never apply.

Bug: 941987
Change-Id: Icec9ec1a2708f488dd2dd0d6c472859b36fb2460

Reviewed-on: https://chromium-review.googlesource.com/2911306
WPT-Export-Revision: 2c84c90fc67005daf9af32b36fdba774124e88da

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/alignment/grid-baseline-align-cycles-001.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51a22fd1170c
[wpt PR 29106] - [GridNG] Updating grid-baseline-align-cycles-001.html, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e177479abb00
[wpt PR 29106] - [GridNG] Updating grid-baseline-align-cycles-001.html, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c2cf69c26d0
[wpt PR 29106] - [GridNG] Updating grid-baseline-align-cycles-001.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6c2cf69c26d0

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.