[wpt-sync] Sync PR 29112 - Update DCHECK for corner case
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 29112 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/29112
Details from upstream follow.
b'Mason Freed <masonf@chromium.org>' wrote:
Update DCHECK for corner case
In a corner case situation (crbug.com/1212619) foster parenting
can lead to a call to ParserInsertBefore() with a |next_child|
value that has a different parent from |this|. This case was
already handled in code, so the DCHECK is updated to allow the
newly-discovered corner case.The relevant spec is
https://html.spec.whatwg.org/multipage/parsing.html#appropriate-place-for-inserting-a-node
from which step 2.5 says:
If last table has a parent node, then let adjusted insertion
location be inside last table's parent node, immediately before
last table, and abort these steps.If, at that point, "inside last table's parent node" is a template
element, it isn't exactly clear whether that means a child of
template's content document, or the template itself.Fixed: 1212619
Change-Id: Iab914f5c39ab6842d92eeae6134f2f347a851e8bReviewed-on: https://chromium-review.googlesource.com/2917760
WPT-Export-Revision: 18d86fa6da8b2e45a25dc0015fb49286b3acd30f
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=31d07a4f40a61ff76ed725ac9a382eeb11157f05
Assignee | ||
Comment 2•3 years ago
|
||
CI Results
Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
PASS: 1
Safari
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5dc5843df322 [wpt PR 29112] - Update DCHECK for corner case, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2d6a7e8265a [wpt PR 29112] - Update DCHECK for corner case, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/869d13cfdd70 [wpt PR 29112] - Update DCHECK for corner case, a=testonly
Comment 6•3 years ago
|
||
bugherder |
Description
•