Closed Bug 1712869 Opened 3 years ago Closed 3 years ago

Upgrade onboarding: On the themes screen, the active theme radio button should be focused by default

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
91 Branch
Iteration:
91.2 - Jun 14 - Jun 27
Project Flags:
Accessibility Severity s4
Tracking Flags:
Tracking Status
firefox91 --- verified

People

(Reporter: Jamie, Assigned: emcminn)

References

Details

(Keywords: access, Whiteboard: [proton-onboarding])

Attachments

(1 file)

Bug 1712869 - Set keyboard focus on the correct button for each screen of the upgrade modal
48 bytes, text/x-phabricator-request
Details | Review

STR:

  1. In about:config, set browser.startup.homepage_override.mstone to 88.0 and browser.startup.upgradeDialog.version to 88. Restart Firefox.
  2. If you are presented with the default browser screen, choose "Not now".
    • Expected: The radio button for the active theme should be focused.
    • Actual: The "Save theme" button is focused.

Since the primary purpose of this screen is for the user to choose a theme, the active theme radio button should be focused. As an analogy, when you open a Save As dialog, the Save button doesn't get focus; the file name text box does. Enter should activate the Save theme button, just as enter activates the Save button in a Save As dialog.

Blocks: 1701086
Whiteboard: [access-s4] → [proton-onboarding][access-s4]
Assignee: nobody → emcminn
Severity: -- → S3
Iteration: --- → 91.1 - May 31 - Jun 13
Priority: -- → P1
Status: NEW → ASSIGNED
Attachment #9226221 - Attachment description: WIP: Bug 1712869 - Set keyboard focus on the correct button for each screen of the upgrade modal → Bug 1712869 - Set keyboard focus on the correct button for each screen of the upgrade modal
Iteration: 91.1 - May 31 - Jun 13 → 91.2 - Jun 14 - Jun 27
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0d561f2e8c8
Set keyboard focus on the correct button for each screen of the upgrade modal r=Mardak

https://hg.mozilla.org/mozilla-central/rev/f0d561f2e8c8

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (91.0a1 Build ID - 20210615214502) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now I can confirm that on the themes screen from the Upgrade modal the active theme radio button is focused by default.

Status: RESOLVED → VERIFIED
status-firefox91: fixed → verified
Accessibility Severity: --- → s4
Whiteboard: [proton-onboarding][access-s4] → [proton-onboarding]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: