1712890 - DRAWWINDOW_DRAW_VIEW is not passed from browser_test_scrollbar_in_extension_popup_window.js to CanvasRenderingContext2D::DrawWindow()

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Sotaro Ikeda [:sotaro]]

browser_test_scrollbar_in_extension_popup_window.js set DRAWWINDOW_DRAW_VIEW as argument. But it is not passed to CanvasRenderingContext2D::DrawWindow().

Comment 1

[Sotaro Ikeda [:sotaro]]

SpecialPowers.snapshotWindow() is called, but it seems not handle option flags.

• https://searchfox.org/mozilla-central/rev/202250ee5931648185c8abb3061d738b15b64067/testing/specialpowers/content/SpecialPowersChild.jsm#1279

It seems better to use snapshotWindowWithOptions().

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1712890 - Use snapshotWindowWithOptions() to pass options

Comment 3

[Sotaro Ikeda [:sotaro]]

:hiro, is it a known problem?

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Of course, I had't noticed. :)

Comment 5

[Sotaro Ikeda [:sotaro]]

Just fixing the test caused test failures.
https://treeherder.mozilla.org/jobs?repo=try&revision=1bddbbab93506980420648c1e4a019501222190d

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&revision=d6507334f8bb67b83a8df8da440c6e25f9c2b4d1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b928e9e3572d
Use snapshotWindowWithOptions() to pass options r=hiro

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b928e9e3572d