Add a basic prompt for selectAudioOutput()
Categories
(Firefox :: Site Permissions, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(10 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
The changes to be posted here are the parts of the selectAudioOutput()
prompt that are expected to be similar to the prompt for getUserMedia()
.
Permanent permissions and grace period are not included here and their model may differ from that of getUserMedia()
.
The work here is sufficient to support a basic authorization model for setSinkId()
and for "audiooutput" devices from enumerateDevices()
.
These are all behind the "media.setsinkid.enabled" pref.
Assignee | ||
Comment 1•3 years ago
|
||
Some testExactPermissionFromPrincipal() wording is from
testPermissionFromPrincipal() and some derived from removed
testExactPermission().
https://hg.mozilla.org/mozilla-central/rev/feba8126032f55aaee9accdfa97eb269e363818e#l2.146
A link to testExactPermissionFromPrincipal() in getPermissionObject() doc
would not be helpful but even misleading because there is no pref lookup for
default permissions.
getPermissionObject() with !exactHost searches base domains, not subdomains.
https://searchfox.org/mozilla-central/rev/1758450798ae14492ba28b695f48143840ad6c5b/extensions/permissions/PermissionManager.cpp#2585-2588
Assignee | ||
Comment 2•3 years ago
|
||
This will allow distinguishing from audioOutputDevices.
Depends on D115989
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D115990
Assignee | ||
Comment 4•3 years ago
|
||
to make the meaning readable at the call site.
This is expected to have further benefit when a speaker device selector is
added.
Depends on D115991
Assignee | ||
Comment 5•3 years ago
|
||
This is expected to have further benefit when a speaker device selector is
added.
Depends on D115992
Assignee | ||
Comment 6•3 years ago
|
||
This contains the code paths that are similar to the prompt for getUserMedia().
Permanent permissions and grace period are not included here and their model
may differ from that of getUserMedia().
See https://bugzilla.mozilla.org/show_bug.cgi?id=1712892
Depends on D115993
Assignee | ||
Comment 7•3 years ago
|
||
Depends on D115994
Assignee | ||
Comment 8•3 years ago
|
||
Depends on D115995
Updated•3 years ago
|
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92ff3bc03f44 rename audio/videoDevices to audio/videoInputDevices r=pbz https://hg.mozilla.org/integration/autoland/rev/adc8b1a4934d return empty string for mediaSource of audiooutput MediaDevice r=jib
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48411fa4aaf2 pass expected device types to checkDeviceSelectors as a single array r=florian https://hg.mozilla.org/integration/autoland/rev/dd16354bdac0 share code for testing microphone and camera selectors r=pbz https://hg.mozilla.org/integration/autoland/rev/eaa0361759fd introduce helper functions for reloading r=jib
Comment 11•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Comment 12•3 years ago
|
||
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f44d8f7f5871 Fill in doc for dangling references and correct non-exact search doc r=timhuang DONTBUILD
Assignee | ||
Comment 13•3 years ago
|
||
Assignee | ||
Comment 14•3 years ago
|
||
Comment 15•3 years ago
|
||
bugherder |
Comment 16•3 years ago
|
||
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5be1ca745588 detect selectAudioOutput() NotFoundError case in content process r=jib
Comment 17•3 years ago
|
||
bugherder |
Assignee | ||
Updated•3 years ago
|
Comment 18•3 years ago
|
||
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15f96a44f4d1 add a basic prompt for selectAudioOutput() r=jib,flod,pbz https://hg.mozilla.org/integration/autoland/rev/26cc46376c50 test selectAudioOutput prompt UI r=jib https://hg.mozilla.org/integration/autoland/rev/af9690fab441 test that escaping selectAudioOutput prompt does not block future prompts r=jib,pbz
Comment 19•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/15f96a44f4d1
https://hg.mozilla.org/mozilla-central/rev/26cc46376c50
https://hg.mozilla.org/mozilla-central/rev/af9690fab441
Description
•