1712907 - ./mach wpt --repeat-until-unexpected doesn't work on Android build setup

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

I got following error;

    ['wpt', 'testing/web-platform/tests/css/css-backgrounds/animations/background-color-animation-with-zero-playbackRate.html']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file wpt| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

UnboundLocalError: local variable 'environ' referenced before assignment

  File "/home/hiro/android/testing/web-platform/mach_commands.py", line 527, in run_wpt
    return self.run_web_platform_tests(command_context, **params)
  File "/home/hiro/android/testing/web-platform/mach_commands.py", line 517, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "/home/hiro/android/testing/web-platform/mach_commands_base.py", line 61, in run
    result = wptrunner.start(**kwargs)
  File "/home/hiro/android/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py", line 416, in start
    rv = not run_tests(**kwargs) or logged_critical.has_log
  File "/home/hiro/android/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py", line 288, in run_tests
    executor_kwargs = product.get_executor_kwargs(logger,
  File "/home/hiro/android/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py", line 192, in executor_kwargs
    del environ["MOZ_DISABLE_NONLOCAL_CONNECTIONS"]

Even without specifying --repeat-until-unexpected I get the same error but the test runs once.

:whimboo told me it was regressed by bug 1678044.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

James, could you have a look at it?

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1712907 - Only try to edit the environment when it's defined,

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b21ce1e340b
Only try to edit the environment when it's defined, r=whimboo

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29125 for changes under testing/web-platform/tests

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3b21ce1e340b

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #4)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/29125 for changes under
testing/web-platform/tests

James, please have a look at the PR. It doesn't get automatically merged. Thanks.

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham