1712983 - Certviewer slowing down page loads with devtools open

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Tomislav Jovanovic :zombie]

See details starting from bug 1684703 comment 24.

Looks like after https://phabricator.services.mozilla.com/D106340 landed, page loads seem to be slowed by 200-400ms (on Core i7) while devtools are open. From this profile it looks like we're pegging the CPU in the parent process https://profiler.firefox.com/public/hqc6swa6sk3fjbbmpgsscfgczhx1nw50mtpspg8/.

It's not terrible since it doesn't seem to happen with devtools closed, but it makes Firefox look bad if folks are using the network devtools panel to test and compare performance vs other browsers.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1688703

Comment 2

[Marco Castelluccio [:marco]]

Dana, since you worked on the regressor bug 1688703, could you look into this?

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I suppose we could memoize the decoded certificates so we don't waste effort decoding the same ones over and over again.

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1712983 - memoize decoded certificates in devtools to avoid unnecessary work r?ochameau

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38ea594ae66e
memoize decoded certificates in devtools to avoid unnecessary work r=ochameau

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/38ea594ae66e

Comment 7

[Peter Hedenskog]

Would it be possible to add one test in the performance tests with devtools open so this is found early if it happens again? See https://bugzilla.mozilla.org/show_bug.cgi?id=1720843