Closed Bug 1713012 Opened 3 years ago Closed 3 years ago

Build warning: warning: Cannot set `RUSTC_BOOTSTRAP=1` from build script of `qcms v0.2.0 (gfx/qcms)`.

Categories

(Core :: Graphics: Color Management, task)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: dholbert, Assigned: jrmuizel, NeedInfo)

References

Details

Attachments

(1 file)

I noticed this build warning go by in my build-spew:

warning: Cannot set RUSTC_BOOTSTRAP=1 from build script of qcms v0.2.0 (gfx/qcms).

note: Crates cannot set RUSTC_BOOTSTRAP themselves, as doing so would subvert the stability guarantees of Rust for your project.

Looks like the RUSTC_BOOTSTRAP=1 line is here:
https://searchfox.org/mozilla-central/diff/0f0c9a9a0c08caf88e305875e1e6376f4a9689a7/gfx/qcms/build.rs#4

...and it was added in the first version of this file in bug 1666057. (It was put behind a guard in bug 1702080, though I'm not sure that makes a difference here.)

Is this warning telling us something useful? Do we actually need or care about having RUSTC_BOOTSTRAP here?

Flags: needinfo?(jmuizelaar)

In bug 1670538 we started setting RUSTC_BOOTSTRAP for Rust 1.50+
Rust 1.50+ gives a warning if we set in build.rs so don't.

Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1a7d3329c70
Only set RUSTC_BOOTSTRAP if it's not already set. r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: