Closed Bug 1713015 Opened 2 months ago Closed 2 months ago

Update the default color override option to respect high contrast themes on Mac

Categories

(Core :: Disability Access APIs, defect, P3)

All
macOS
defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
relnote-firefox --- ?
firefox91 --- fixed

People

(Reporter: morgan, Assigned: morgan)

References

(Regressed 1 open bug)

Details

Attachments

(1 file)

Previously we didn't support mac's native high contrast mode and so it made sense to set "override with system colors?" to "never". Currently, though, if you enable "Increased contrast" in MacOS System Prefs, you see no changes to Firefox because of the default option-- we should make it easier for users to benefit from FF HCM by enabling HCM when MacOS's Increase Contrast is checked.

Attachment #9223659 - Attachment description: WIP: Bug 1713015: Default browser.display.document_color_use to 0 on MacOS r?emilio → Bug 1713015: Default browser.display.document_color_use to 0 on MacOS r?emilio
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/550fd06e9120
Default browser.display.document_color_use to 0 on MacOS r=emilio

Backed out changeset 550fd06e9120 (Bug 1713015) for causing bc failures in browser_HCM_telemetry.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/c2684115028cad5f3834e099c6de068c8cb503d8
Push with failures, failure log.

Flags: needinfo?(mreschenberg)
Flags: needinfo?(mreschenberg)
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52ed1b7f1fb0
Default browser.display.document_color_use to 0 on MacOS r=emilio
Regressions: 1714469
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Morgan, is that worth mentioning in our release notes? If you think it is, could you request an addition? Thanks!

https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_decide_whether_a_change_should_be_included_in_release_notes.3F

Flags: needinfo?(mreschenberg)

Release Note Request (optional, but appreciated)
[Why is this notable]: We've had support for high contrast mode on Mac for a few releases now, but in order for users to benefit from our support, they had to have prior knowledge of FF's HCM preferences and know to enable HCM in the browser as well as the OS. Now, the browser will automatically enable HCM when it detects MacOS's system preference is set.
[Affects Firefox for Android]: No
[Suggested wording]: Firefox now automatically enables High Contrast Mode when "Increase Contrast" is checked on MacOS.
[Links (documentation, blog post, etc)]: N/A

relnote-firefox: --- → ?
Flags: needinfo?(mreschenberg)

Note added to nightly release notes, thanks.

You need to log in before you can comment on or make changes to this bug.