Closed Bug 1713036 Opened 5 years ago Closed 5 years ago

Update DoH Preferences UI to work with Remote Settings config

Categories

(Firefox :: Security, defect, P1)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox90 --- verified
firefox91 --- fixed

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 external file)

Needs some thought and possibly product specs to be actionable.

I realized that this is more impactful than I first thought... we should probably uplift this.

Severity: S4 → S2
Type: enhancement → defect
Priority: P2 → P1

[Tracking Requested - why for this release]:
Without this, the user may face issues when choosing their provider in about:preferences, particularly when we roll out in Canada with the new config system.

Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attachment #9227308 - Attachment description: Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=jaws! → Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=jaws!,#necko!
Attachment #9227308 - Attachment description: Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=jaws!,#necko! → Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=#necko!
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6ce07df62710 Use Remote Settings config in DoH preferences UI. r=jaws,preferences-reviewers,necko-reviewers,valentin
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/06c40198b074 Use Remote Settings config in DoH preferences UI. r=jaws,preferences-reviewers,necko-reviewers,valentin

Gah, I missed the socket-process TRRService impl. Third time's the charm?

Flags: needinfo?(nhnt11)
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/06800c1388fb Use Remote Settings config in DoH preferences UI. r=jaws,preferences-reviewers,necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
See Also: → 1717988
Depends on: 1718097

Let's not uplift this.

Regressions: 1718097

Comment on attachment 9227308 [details]
Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=#necko!

Beta/Release Uplift Approval Request

  • User impact if declined: This uplift is in support of unblocking our rollout of DoH in Canada. The patches for which uplift is being requested update the DoH settings UI to work better with Remote Settings, and simplify the Normandy recipe for the rollout.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1713036, Bug 1720379, Bug 1718097, Bug 1719851, Bug 1714486
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): The changes have been baking for a while and work well. Medium risk because of the number of patches we need to uplift.
  • String changes made/needed:
Attachment #9227308 - Flags: approval-mozilla-release?
  • We verified this issue across platforms (Windows 10 x64, Ubuntu 20 x64, macOS 11.4) using the 90.0.2 try-build provided by Nihanth. We performed smoke testing using the Remote Settings Stage environment on the DoH Preferences UI and didn't encounter any issues. The DNS providers are correctly switched and the preferences are set accordingly.

Comment on attachment 9227308 [details]
Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=#necko!

approved for 90.0.2

Attachment #9227308 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: