Update DoH Preferences UI to work with Remote Settings config
Categories
(Firefox :: Security, defect, P1)
Tracking
()
People
(Reporter: nhnt11, Assigned: nhnt11)
References
Details
Attachments
(1 external file)
Needs some thought and possibly product specs to be actionable.
| Assignee | ||
Comment 1•5 years ago
|
||
I realized that this is more impactful than I first thought... we should probably uplift this.
| Assignee | ||
Comment 2•5 years ago
|
||
[Tracking Requested - why for this release]:
Without this, the user may face issues when choosing their provider in about:preferences, particularly when we roll out in Canada with the new config system.
| Assignee | ||
Comment 3•5 years ago
|
||
Depends on D116798
Updated•5 years ago
|
Updated•5 years ago
|
| Assignee | ||
Comment 4•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 7•5 years ago
•
|
||
Backed out for xpcshell and browser chrome failures.
They were failing also on the fix patch: https://treeherder.mozilla.org/jobs?repo=autoland&tochange=a516d0598b2ab9b2920d513bcdb8e7e8805666bc&fromchange=3afce31662197d5b85286e9726805c74ea1585df&failure_classification_id=2&selectedTaskRun=Z_QhiKAUQOSnFqW9PBFkMg.0
Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=343577523&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=343577699&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/a516d0598b2ab9b2920d513bcdb8e7e8805666bc
| Assignee | ||
Comment 8•5 years ago
|
||
Comment 10•5 years ago
|
||
Backed out 2 changesets (bug 1713036, bug 1714486) for XPCshell failures in netwerk/test/unit/test_trr.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=343649984&repo=autoland&lineNumber=4387
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=06c40198b07487ade14e363a7e82a41df6c83cde
Backout:
https://hg.mozilla.org/integration/autoland/rev/997eb0fed0378b1c4ddd5b0eadf589c40e5e84a2
| Assignee | ||
Comment 11•5 years ago
|
||
Gah, I missed the socket-process TRRService impl. Third time's the charm?
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 15•5 years ago
|
||
Comment on attachment 9227308 [details]
Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=#necko!
Beta/Release Uplift Approval Request
- User impact if declined: This uplift is in support of unblocking our rollout of DoH in Canada. The patches for which uplift is being requested update the DoH settings UI to work better with Remote Settings, and simplify the Normandy recipe for the rollout.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1713036, Bug 1720379, Bug 1718097, Bug 1719851, Bug 1714486
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): The changes have been baking for a while and work well. Medium risk because of the number of patches we need to uplift.
- String changes made/needed:
Comment 16•5 years ago
|
||
- We verified this issue across platforms (Windows 10 x64, Ubuntu 20 x64, macOS 11.4) using the 90.0.2 try-build provided by Nihanth. We performed smoke testing using the Remote Settings Stage environment on the DoH Preferences UI and didn't encounter any issues. The DNS providers are correctly switched and the preferences are set accordingly.
Updated•5 years ago
|
Comment 17•5 years ago
|
||
Comment on attachment 9227308 [details]
Bug 1713036 - Use Remote Settings config in DoH preferences UI. r=#necko!
approved for 90.0.2
Comment 18•5 years ago
|
||
| bugherder uplift | ||
Updated•5 years ago
|
Description
•