Closed
Bug 1713116
Opened 3 years ago
Closed 3 years ago
Replace "mediakeys-request" literal with a constant, static string
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: bryce, Assigned: bryce)
Details
Attachments
(1 file)
"mediakeys-request" is a literal we use to distinguish some MediaKeys related notifications and messages in the code[0]. The literal is used in a few places and could be replaced with a variable. Since we have a variable for responses[1] it makes sense to pair it with one for requests.
[0] https://searchfox.org/mozilla-central/rev/2b372b94ce057097a6ef8eb725f209faa9d1dc4d/dom/media/eme/MediaKeySystemAccess.cpp#1164
[1] https://searchfox.org/mozilla-central/rev/2b372b94ce057097a6ef8eb725f209faa9d1dc4d/dom/media/eme/MediaKeys.h#218
|
Assignee | |
Updated•3 years ago
|
Summary: Replace "mediakeys-request" literal with a constant + static string → Replace "mediakeys-request" literal with a constant, static string
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1eb28bab9e3 Replace "mediakeys-request" literal with MediaKeys::kMediaKeysRequestTopic in C++ code. r=alwu
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•