1713119 - Checking browsertime version fails with recent versions of node/npm

Status: RESOLVED FIXED

(Testing :: Raptor, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Running Raptor locally on my MacBook Pro results in the following error:

KeyError('_from')

This appears to be related to keys missing from tools/browsertime/node_modules/browsertime/package.json. After some investigation it appears there has been a change in the way node/npm behaves when installing packages. See https://github.com/npm/rfcs/pull/38 for more details.

I suspect the reason I'm seeing this now is due to bug 1706545, which updated the version of node used on my machine. I believe we should attempt to gather the source URL from .package-lock.js where it's available and fallback to the current behaviour.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1713119: Attempt to resolve tarball used to install Browsertime from .package-lock.json; r=#perftest

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5490d627b1f0
Attempt to resolve tarball used to install Browsertime from .package-lock.json; r=perftest-reviewers,sparky

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1706545

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5490d627b1f0