Closed
Bug 1713119
Opened 3 years ago
Closed 3 years ago
Checking browsertime version fails with recent versions of node/npm
Categories
(Testing :: Raptor, defect)
Tracking
(firefox-esr78 unaffected, firefox88 unaffected, firefox89 unaffected, firefox90 fixed)
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | --- | unaffected |
| firefox90 | --- | fixed |
People
(Reporter: davehunt, Assigned: davehunt)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Running Raptor locally on my MacBook Pro results in the following error:
KeyError('_from')
This appears to be related to keys missing from tools/browsertime/node_modules/browsertime/package.json. After some investigation it appears there has been a change in the way node/npm behaves when installing packages. See https://github.com/npm/rfcs/pull/38 for more details.
I suspect the reason I'm seeing this now is due to bug 1706545, which updated the version of node used on my machine. I believe we should attempt to gather the source URL from .package-lock.js where it's available and fallback to the current behaviour.
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by dhunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5490d627b1f0 Attempt to resolve tarball used to install Browsertime from .package-lock.json; r=perftest-reviewers,sparky
|
||
Comment 3•3 years ago
|
||
Set release status flags based on info from the regressing bug 1706545
status-firefox88:
--- → unaffected
status-firefox89:
--- → unaffected
status-firefox90:
--- → affected
status-firefox-esr78:
--- → unaffected
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
|
|
||
Updated•3 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•