1713125 - Crash in [@ mozilla::dom::ScriptLoader::HandleLoadError]

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P3)

Description

[Sean Feng [:sefeng]]

Crash report: https://crash-stats.mozilla.org/report/index/91474d7c-12c9-49b1-9f53-e03900210501

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (mPreloads.RemoveElement(aRequest, PreloadRequestComparator()))

Top 10 frames of crashing thread:

0 XUL mozilla::dom::ScriptLoader::HandleLoadError dom/script/ScriptLoader.cpp:4042
1 XUL mozilla::dom::ScriptLoadHandler::OnStreamComplete dom/script/ScriptLoadHandler.cpp:414
2 XUL nsIncrementalStreamLoader::OnStopRequest netwerk/base/nsIncrementalStreamLoader.cpp:85
3 XUL nsCORSListenerProxy::OnStopRequest netwerk/protocol/http/nsCORSListenerProxy.cpp:612
4 XUL nsBaseChannel::OnStopRequest netwerk/base/nsBaseChannel.cpp:849
5 XUL {virtual override thunk} 
6 XUL nsInputStreamPump::OnStateStop netwerk/base/nsInputStreamPump.cpp:649
7 XUL nsInputStreamPump::OnInputStreamReady netwerk/base/nsInputStreamPump.cpp:397
8 XUL nsInputStreamReadyEvent::Run xpcom/io/nsStreamUtils.cpp:94
9 XUL mozilla::SchedulerGroup::Runnable::Run xpcom/threads/SchedulerGroup.cpp:143

Comment 1

[Nicolas B. Pierron [:nbp]]

Denis, maybe you would have ideas on what might be going wrong.

Comment 2

[Nicolas B. Pierron [:nbp]]

This seems related to the script Preload of modules added by Bug 1342416.
Would you have any idea what might be wrong here?

Comment 3

[Jon Coppeard (:jonco)]

It's true that I added the MOZ_ALWAYS_TRUE() that is failing in bug 1342416. This is probably related to script loading in general though.

I don't know why it's failing. We always add preload requests to the mPreloads array if StartLoad() is successful, and there doesn't appear to be any way we can fail after we open the channel but before that happens.

That said, the script loader could do with some stronger invariant checking in general which might turn up something.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.