Closed Bug 1713134 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27875 - Add `RTCRtpSource::SenderCaptureTimeOffset`

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27875 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27875
Details from upstream follow.

b'Alessio Bazzica <alessiob@chromium.org>' wrote:

Add RTCRtpSource::SenderCaptureTimeOffset

The implementation is according to [1]; an intent was filed on
blink-dev (see [2]).
The unit tests for RTCRtpSynchronizationSource.senderCaptureTimeOffset
are an adaption of [3]. Note that step_timeout has been replaced with
step_wait both in the new test and in [3].
This CL needs [4] which fixes the clock offset reference clock in
WebRTC.

[1] https://w3c.github.io/webrtc-extensions/#dom-rtcrtpcontributingsource-sendercapturetimeoffset
[2] https://groups.google.com/a/chromium.org/g/blink-dev/c/SRfE60yI0uc
[3] third_party/blink/web_tests/external/wpt/webrtc-extensions/RTCRtpSynchronizationSource-captureTimestamp.html
[4] https://webrtc-review.googlesource.com/c/src/+/219163

Bug: chromium:1056230, webrtc:10739
Change-Id: I610e2dac614be27927557939243cb9bbb597780c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2731987
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Commit-Queue: Alessio Bazzica \<alessiob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#887115}

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
PASS : 8
FAIL : 6

Chrome

OK : 2
PASS : 11
FAIL : 3

Safari

TIMEOUT: 4
NOTRUN : 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webrtc-extensions/RTCRtpSynchronizationSource-captureTimestamp.html
[audio] getSynchronizationSources() should contain captureTimestamp if absolute capture time RTP header extension is negotiated: FAIL (Chrome: PASS, Safari: NOTRUN)
[video] getSynchronizationSources() should contain captureTimestamp if absolute capture time RTP header extension is negotiated: FAIL (Chrome: PASS, Safari: NOTRUN)
Audio and video RTCRtpSynchronizationSource.captureTimestamp are comparable: FAIL (Chrome: PASS, Safari: NOTRUN)
/webrtc-extensions/RTCRtpSynchronizationSource-senderCaptureTimeOffset.html
[audio] getSynchronizationSources() should contain senderCaptureTimeOffset if absolute capture time RTP header extension is negotiated: FAIL (Chrome: FAIL, Safari: NOTRUN)
[video] getSynchronizationSources() should contain senderCaptureTimeOffset if absolute capture time RTP header extension is negotiated: FAIL (Chrome: FAIL, Safari: NOTRUN)
Audio and video RTCRtpSynchronizationSource.senderCaptureTimeOffset must be zero: FAIL (Chrome: FAIL, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97e54cd44661
[wpt PR 27875] - Add `RTCRtpSource::SenderCaptureTimeOffset`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/195ae689b864
[wpt PR 27875] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/97e54cd44661
https://hg.mozilla.org/mozilla-central/rev/195ae689b864

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.