Closed Bug 1713154 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29141 - Fix Android AudioParam test failures

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29141 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29141
Details from upstream follow.

b'Raymond Toy <rtoy@chromium.org>' wrote:

Fix Android AudioParam test failures

Update test thresholds so that tests pass on my Pixel 4a (5G) device.

The thresholds are widened slightly which is deemed small enough not
to impact test coverage.

Bug: 1212851
Change-Id: Ic0c66d22e7bfbe8e94663c30765521d59f715c4b
Reviewed-on: https://chromium-review.googlesource.com/2921018
WPT-Export-Revision: 0cdde6a35e740e75dd52ad2fabf4e30c0ffd6ee4

PR 29141 applied with additional changes from upstream: e888fa12c505ad2793fac96ab3158e42e861bf84
Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 67 subtests

Status Summary

Firefox

OK : 2
PASS: 89
FAIL: 19

Chrome

OK : 2
PASS: 173

Safari

OK : 2
PASS: 173

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold.html
Executing "linear": FAIL
Executing "exponential": FAIL
Executing "setTarget": FAIL
Executing "setValueCurve": FAIL
Executing "setValueCurve after end": FAIL
Executing "initial setTarget": FAIL
Executing "post cancel: Linear": FAIL
Executing "post cancel: Exponential": FAIL
Executing "post cancel: ValueCurve": FAIL
Executing "post cancel: setTarget": FAIL
Executing "post cancel: setValue": FAIL
Executing "cancel future setTarget": FAIL
Executing "cancel setTarget now": FAIL
Executing "cancel future setValueCurve": FAIL
Executing "cancel setValueCurve now": FAIL
Executing "linear, cancel, linear, cancel, linear": FAIL

New Tests That Don't Pass

/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold.html
Executing "linear": FAIL (Chrome: PASS, Safari: PASS)
Executing "exponential": FAIL (Chrome: PASS, Safari: PASS)
Executing "setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "setValueCurve": FAIL (Chrome: PASS, Safari: PASS)
Executing "setValueCurve after end": FAIL (Chrome: PASS, Safari: PASS)
Executing "initial setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: Linear": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: Exponential": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: ValueCurve": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "post cancel: setValue": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel future setTarget": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel setTarget now": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel future setValueCurve": FAIL (Chrome: PASS, Safari: PASS)
Executing "cancel setValueCurve now": FAIL (Chrome: PASS, Safari: PASS)
Executing "linear, cancel, linear, cancel, linear": FAIL (Chrome: PASS, Safari: PASS)
X cancelAndHoldAtTime(-1) threw "TypeError" instead of EcmaScript error RangeError.: FAIL
< [cancelTime] 1 out of 3 assertions were failed.: FAIL

AUDIT TASK RUNNER FINISHED: 1 out of 17 tasks were failed.: FAIL

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42bbdc972ab5
[wpt PR 29141] - Fix Android AudioParam test failures, a=testonly

https://hg.mozilla.org/mozilla-central/rev/42bbdc972ab5

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.