1713285 - Cleanups to prepare for bug 1704430

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

A collection of patches to prepare for later changes.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 1 - Rename PropertyInfo to PropertySnapshot. r?evilpie!

We want to use the naem PropertyInfo for ShapeProperty instead.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 2 - Rename ShapePropertyFlag{s} to PropertyFlag{s}. r?evilpie!

Depends on D116224

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 3 - Rename ShapePropertyWithKey to PropertyInfoWithKey. r?evilpie!

Also move the Vector type to ShapeProperty.h

Depends on D116225

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 4 - Rename ShapeProperty to PropertyInfo. r?evilpie!

Depends on D116226

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 5 - Rename ShapeProperty.h to PropertyInfo.h. r?evilpie!

Depends on D116227

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 6 - Add vm/PropertyKey.h header. r?jonco!

This lets us move code out of Shape.h to simplify later changes.

Depends on D116228

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 7 - Modernize vm/PropertyKey.h code. r?jonco!

Depends on D116229

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 8 - Remove some unnecessary forward and friend declarations. r?jonco!

Depends on D116230

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 9 - Move ObjectFlags out of Shape header files. r?jonco!

Depends on D116231

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 10 - Simplify initial shapes table. r?jonco!

This is similar to the BaseShape table: use WeakHeapPtr<Shape*> directly so
that we don't need the explicit fixup code for compacting GC.

Depends on D116232

Comment 11

[Jan de Mooij [:jandem]]

Attachment: Bug 1713285 part 11 - Add ShapeZone. r?jonco!

Depends on D116233

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12db0e4b7fdf
part 1 - Rename PropertyInfo to PropertySnapshot. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/c2be3188a644
part 2 - Rename ShapePropertyFlag{s} to PropertyFlag{s}. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/a2b8d2cfbec7
part 3 - Rename ShapePropertyWithKey to PropertyInfoWithKey. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/914921932cf3
part 4 - Rename ShapeProperty to PropertyInfo. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/ce2d267cdd4f
part 5 - Rename ShapeProperty.h to PropertyInfo.h. r=evilpie

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/12db0e4b7fdf
https://hg.mozilla.org/mozilla-central/rev/c2be3188a644
https://hg.mozilla.org/mozilla-central/rev/a2b8d2cfbec7
https://hg.mozilla.org/mozilla-central/rev/914921932cf3
https://hg.mozilla.org/mozilla-central/rev/ce2d267cdd4f

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6409fbf0834
part 6 - Add vm/PropertyKey.h header. r=jonco
https://hg.mozilla.org/integration/autoland/rev/8ff57f540e79
part 7 - Modernize vm/PropertyKey.h code. r=jonco
https://hg.mozilla.org/integration/autoland/rev/5e0df79afea0
part 8 - Remove some unnecessary forward and friend declarations. r=jonco
https://hg.mozilla.org/integration/autoland/rev/e5260c512ea8
part 9 - Move ObjectFlags out of Shape header files. r=jonco
https://hg.mozilla.org/integration/autoland/rev/82068f7ae696
part 10 - Simplify initial shapes table. r=jonco
https://hg.mozilla.org/integration/autoland/rev/dc39afe35ec8
part 11 - Add ShapeZone. r=jonco

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d6409fbf0834
https://hg.mozilla.org/mozilla-central/rev/8ff57f540e79
https://hg.mozilla.org/mozilla-central/rev/5e0df79afea0
https://hg.mozilla.org/mozilla-central/rev/e5260c512ea8
https://hg.mozilla.org/mozilla-central/rev/82068f7ae696
https://hg.mozilla.org/mozilla-central/rev/dc39afe35ec8