[comm_taskgraph] - reduce excess build jobs - linting, once-a-day builds
Categories
(Thunderbird :: Build Config, task)
Tracking
(thunderbird_esr78 unaffected, thunderbird90 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird90 | --- | unaffected |
People
(Reporter: rjl, Assigned: rjl)
References
Details
Attachments
(6 files, 2 obsolete files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
The source linters run even on suite-only pushes. A composite optimization strategy combining no-suite with when-files-changed would be more appropriate.
There's also a handful of builds (win-plain, ASan, and linux-aarch64) that only need to run if building a daily build.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Prevents these jobs from running when only Seamonkey-associated files are
changed in the push.
Depends on D116268
Assignee | ||
Comment 3•3 years ago
|
||
Some build jobs need to run, but not necessarily on every push. At the moment,
this includes the ASan builds, and the Windows plain builds.
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D116709
Assignee | ||
Updated•3 years ago
|
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/7af9a61bba49
Create taskgraph optimization strategy combining no-suite and files-changed. r=justdave
https://hg.mozilla.org/comm-central/rev/70c8a00a64b3
Use skip-unless-changed-no-suite taskgraph optimization strategy on source-test jobs. r=justdave
https://hg.mozilla.org/comm-central/rev/ff95d0a57315
Optimization strategy for jobs that only need to run once a day. r=justdave
https://hg.mozilla.org/comm-central/rev/25979118e932
Run ASan and windows-plain builds once a day. r=justdave
Assignee | ||
Comment 6•3 years ago
•
|
||
The nightly_desktop
target_tasks_method will not grab these builds though, so the optimization including them does no good.
I'm going to wind up backing out two of these patches (ff95d0a57315 and 25979118e932) and using a backstop optimization strategy like I should have in the first place. That will require some M-C changes, but they're pretty minor and backstop builds are pretty useful.
Assignee | ||
Comment 7•3 years ago
|
||
Backout of ff95d0a57315 and 25979118e932:
https://hg.mozilla.org/comm-central/rev/039f7587239682194c099b791d617e9c6c79f731
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 8•3 years ago
|
||
Set up backstop optimizer to run jobs roughly once a day.
Assignee | ||
Comment 9•3 years ago
|
||
Depends on D117171
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/c5e77eb3677a
Set up skip-if-backtop optimizer for comm-central builds. r=justdave
https://hg.mozilla.org/comm-central/rev/2304a3ea719f
Use backstop optimizer combined with no-suite for non-product build platforms. r=justdave
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 11•3 years ago
|
||
is_backstop needs to be reset prior to calling it a second time. The trust_domain
also needs to be passed to locate the previous backstop push.
Assignee | ||
Updated•3 years ago
|
Comment 12•3 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/0484d2b5e0fc
Reset backstop parameter and call is_backstop with correct trust domain. r=justdave
Assignee | ||
Updated•3 years ago
|
Comment 13•3 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/cd260bbf8dc0
Temporarily disable TSAN/ASan builds. r=me
Comment 14•3 years ago
|
||
Pushed by thunderbird@calypsoblue.org: https://hg.mozilla.org/comm-central/rev/af337802848e Follow-up: Really disable Linux TSAN. r=me
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 15•3 years ago
|
||
Test optimization strategy needs to align with the build strategy. If the test
strategy determines that the test needs to run, by definition the build must run.
The optimization attribute doesn't normally allow setting a different strategy
based on the test platform. This is useful for Thunderbird, and doesn't align
with the way Firefox CI runs tests.
Comment 16•3 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/d7a6a775e441
Taskgraph transform to allow setting optimization strategy by-platform for tests. r=justdave
Description
•