Closed Bug 1713323 Opened 3 years ago Closed 3 years ago

Add window switching handling to page view time for history metadata

Categories

(Firefox :: Bookmarks & History, task, P2)

task
Points:
5

Tracking

()

RESOLVED FIXED
91 Branch
Iteration:
91.1 - May 31 - Jun 13
Tracking Status
firefox91 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1712941 was landed without active window tracking, to allow for a smaller patch and getting a better base landed. This bug will add active window tracking to the page view time.

Blocks: 1713325
Attachment #9224010 - Attachment description: WIP: Bug 1713323 - Add window switching handling to page view time for history metadata. → Bug 1713323 - Add window switching handling to page view time for history metadata. r?mak!
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7315ee22da8e Add window switching handling to page view time for history metadata. r=mak,acreskey

This was due to not waiting long enough when switching to the private browsing window before switching back again - we now wait for focus and an additional waitForTick, which seems to be long enough to fix the intermittent.

I've also identified an issue with some of the existing tests which mainly shows up on test-verify. I'll get that filed/patched as well.

Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0b5df171b00 Add window switching handling to page view time for history metadata. r=mak,acreskey
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: