1713426 - [x] Close button to remove Cc/Bcc address rows is not keyboard-accessible

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Thomas D. (:thomas8)]

Seen on Daily 90.0a1 (2021-05-28) (64-bit), Win10.

STR

1. compose
2. Ctrl+Shift+C to open Cc field
3. Shift+Tab to focus [x] close button of Cc field
4. Press Enter or Space

Actual

• Enter: nothing
• Space: visual feedback, but no action

Expected

• Remove Cc field

Probably regressed by bug 1683865, attachment 9223240 [details]:
https://phabricator.services.mozilla.com/D115827

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Thomas D. (:thomas8) from comment #0)

Seen on Daily 90.0a1 (2021-05-28) (64-bit), Win10.

STR

1. compose
2. Ctrl+Shift+C to open Cc field
3. Shift+Tab to focus [x] close button of Cc field
4. Press Enter or Space

Actual

• Enter: nothing
• Space: visual feedback, but no action

Expected

• Remove Cc field

Probably regressed by bug 1683865, attachment 9223240 [details]:
https://phabricator.services.mozilla.com/D115827

Yes, this was my patch. I had assumed that XUL button had the same click behaviour as HTML button. I should have just converted straight to a HTML button.

Also, Space didn't work before my patch either, but using a HTML button should fix this.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1713426 - Convert the addresses field close button from a xul:button into a html:button. r=mkmelin

HTML buttons automatically receive the "click" event on "Space" and "Enter" keypresses.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/755138d182fe
Convert the addresses field close button from a xul:button into a html:button. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Bug 1713429 deleted the rule you changed in messengercompose.css, so I left it deleted removing your change.

Comment 5

[Magnus Melin [:mkmelin]]

Henry, please make a patch to update the localization id per the discussion on phab.

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1713426 - Rename remove address field button fluent id. r=mkmelin

The attribute changed from .tooltiptext to .title in 755138d182fe. The same id should not be used when attributes are added or removed, so a new one is needed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/056c8cda44b4
Rename remove address field button fluent id. r=mkmelin