1713439 - MessageHandler: Initial MessageHandler support for content windows

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

Land a basic CommandsHandler support, which can only target content window global contexts.

This should be similar to what is done in the prototype patch https://phabricator.services.mozilla.com/D115473

Comment 1

[Julian Descottes [:jdescottes]]

Note that the basic architecture should already satisfy the main requirements for CommandsHandler, meaning:

• spawn modules in any relevant layer (parent process or content process main thread here)
• support multiple sessions
• route commands from the parent process to content process main thread context
• intercept commands in the parent process targeting a content window global context

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1713439 - [remote] Add basic MessageHandler support for window global contexts

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1713439 - [remote] Add logs to initial MessageHandler classes

Depends on D119780

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1713439 - [remote] Use a MessageHandler to handle packets received by the WebDriverBiDiConnection

Depends on D120082

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1713439 - [remote] Add mochitests to exercize message-handler API

Depends on D120083

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1713439 - [remote] Add MessageHandler subclasses for each supported type

Depends on D120083

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: MessageHandler_scenario_1.svg

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: MessageHandler_scenario_2.svg

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: MessageHandler_scenario_3.svg

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: MessageHandler_scenario_2.svg

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: MessageHandler_scenario_3.svg

Comment 12

[Julian Descottes [:jdescottes]]

Fixed the SVG diagrams.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f355f7623d5
[remote] Add basic MessageHandler support for window global contexts r=webdriver-reviewers,whimboo,jgraham
https://hg.mozilla.org/integration/autoland/rev/6bc2c4e3190f
[remote] Add logs to initial MessageHandler classes r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/26d7b5c2a6ae
[remote] Use a MessageHandler to handle packets received by the WebDriverBiDiConnection r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/99c88470ce60
[remote] Add mochitests to exercize message-handler API r=webdriver-reviewers,whimboo

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6f355f7623d5
https://hg.mozilla.org/mozilla-central/rev/6bc2c4e3190f
https://hg.mozilla.org/mozilla-central/rev/26d7b5c2a6ae
https://hg.mozilla.org/mozilla-central/rev/99c88470ce60