1713470 - Add identify command to cZ and hook into password management

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

This is partially based on parts of the following two commits but with some reworking to remove code duplication:
https://github.com/Ascrod/ambassador/commit/2da104e886a7abb489780583598ad4ea4ef523bd
https://github.com/Ascrod/ambassador/commit/e07206deac14e5a86b157b9e591d182a25cf828a

Comment 1

[Ian Neal]

Attachment: 1713470-irc-passwords-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no password management
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 13 new strings

Comment 2

[Ian Neal]

Attachment: 1713470-irc-passwords-v1_1-25310.patch

Changes since last version:

• When saving password for identify, save against network URL rather than server URL

Comment 3

[Ian Neal]

Attachment: 1713470-irc-passwords-v1_2-25310.patch

Changes since previous version:

• Store passwords in password manager against username rather than nickname

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9232954 [details] [diff] [review]
1713470-irc-passwords-v1_2-25310.patch

LGTM

tonymec How is the latest 2.53.10b1 pre with hti patch doing for you?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f344789406f9
Add identify command to cZ and hook into password management. r=frg

Comment 6

[Tony Mechelynck [:tonymec]]

(In reply to Frank-Rainer Grahl (:frg) from comment #4)

Sorry for late reply.

Comment on attachment 9232954 [details] [diff] [review]
1713470-irc-passwords-v1_2-25310.patch

LGTM

tonymec How is the latest 2.53.10b1 pre with hti patch doing for you?

I don't know. I've gone back to "standard" NickServ operation, bypassing the PwMgr: no annoying popups, I know how to use it, and in particular I know how to make sure there will be a re-login without my intervention after the remote server disconnects (for example on ping timeout). Using NS IDENTIFY rather than MSG NickServ IDENTIFY avoids displaying the password in any cZ tab. (Of course, you can find it in my prefs if you know where to look, but I'm the only user of this PC and I bet that a casual passerby wouldn't know cZ well enough to know where to look. I even believe that it's better hidden in the cZ prefs than in the password manager.)

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/6efdb1f4bf8ec9d8a66c723e1ac764a2a5c5dedc
Add identify command to cZ and hook into password management. r=frg a=frg