1713491 - Return std::pair from nsIFrame::GetOffsets

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Currently it returns nsresult but it never fails.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1713491 - Remove return type of nsIFrame::GetOffsets r=emilio

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1713491 - Return std::pair from nsIFrame::GetOffsets r=emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a722491ae6b3
Remove return type of nsIFrame::GetOffsets r=emilio

Comment 4

[Marian-Vasile Laza]

Backed out changeset a722491ae6b3 (Bug 1713491) on devs request
Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17e7b969b830
Return std::pair from nsIFrame::GetOffsets r=emilio

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset 17e7b969b830 (bug 1713491) for Linux build bustage in gecko/dom/events/ContentEventHandler.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=342517643&repo=autoland&lineNumber=8419

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=17e7b969b83077db1b5043826a0e7ee311052693

Backout:
https://hg.mozilla.org/integration/autoland/rev/081d7e3f74937c9742979ba81b36c34044fe0915

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa6c7477c4d2
Return std::pair from nsIFrame::GetOffsets r=emilio

Comment 8

[Atila Butkovits]

Backed out for causing build bustages on nsIFrame.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f49285e0526b24a73dc247e6aecf259d81b642b8

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&revision=aa6c7477c4d2a92300713a8dd73984e0f28c0e46&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2Cbb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=342545721&repo=autoland&lineNumber=44581

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9cc2b752dc3
Return std::pair from nsIFrame::GetOffsets r=emilio

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b9cc2b752dc3