1713523 - dom/crypto/CryptoBuffer.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Core :: DOM: Web Crypto, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1713522 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/dom/crypto/CryptoBuffer.cpp#50-56
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/dom/crypto/CryptoBuffer.cpp#64-68

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Nayeem Hasan]

Hi, can I work on this?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

yes

Comment 3

[Nayeem Hasan]

Attachment: Bug 1713523 - Remove 'else' after 'return' in CryptoBuffer. r=andi

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nayeemhasan.nh01, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fc38a2485d4
Remove 'else' after 'return' in CryptoBuffer. r=andi

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7fc38a2485d4