1713528 - widget/GfxInfoBase.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/widget/GfxInfoBase.cpp#315-357
Remove all the "else", they are useless

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Jakob Spahn]

There are further occurrences of 'else if' statements after 'return' in functions other than 'BlocklistOSToOperatingSystem':
https://searchfox.org/mozilla-central/source/widget/GfxInfoBase.cpp#452-475

Should I leave those open for future good first bug opportunities?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

sure, don't hesitate to fix them here too

Comment 3

[Jakob Spahn]

Attachment: Bug 1713528 - Change 'else if' after return to 'if'. r?aosmond

Comment 4

[Jakob Spahn]

Sorry for bothering, but I can't land the stack myself (don't have level 3 commit access).
Am I supposed to get this access level, or can someone else land this?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef897f64483e
Change 'else if' after return to 'if'. r=aosmond

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ef897f64483e

Comment 7

[Sylvestre Ledru [:Sylvestre]]

done :)