Closed Bug 1713588 Opened 3 years ago Closed 3 years ago

Don't sync shadow text on GeckoEditable during composing

Categories

(GeckoView :: General, defect, P1)

Unspecified
All

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Although I cannot reproduce https://github.com/mozilla-mobile/fenix/issues/4208, I would like to improve race issue of synchronizing Gecko text with Java text.

Gecko's text API has a hint whether text change notification is by composing. If by composing, it is unnecessary to sync it because it doesn't block/change by JavaScript. It means that shadow (Java) text is matched to Gecko text.

Actually, we don't consider it, so I would like to ignore synchronizing text (not calling icSyncShadowText) if composing.

Gecko's text API has a hint whether text change notification is by IME
composing. If by IME composing, it is unnecessary to synchronize it by
onSelectionChange because JavaScript doesn't block/change inputted text.
It means that shadow (Java) text is always matched to Gecko text.

So we don't have to synchronize shadow text during composing.

Severity: -- → S3
Priority: -- → P1
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/e91b5e9cd1e7
Don't sync shadow text during composing. r=geckoview-reviewers,agi
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: